http://bugzilla.novell.com/show_bug.cgi?id=599186
http://bugzilla.novell.com/show_bug.cgi?id=599186#c0
Summary: ocs - commit: double up-load ? ...g Classification: openSUSE Product: openSUSE.org Version: unspecified Platform: Other OS/Version: Other Status: NEW Severity: Major Priority: P5 - None Component: BuildService AssignedTo: bnc-team-screening@forge.provo.novell.com ReportedBy: mmeeks@novell.com QAContact: adrian@novell.com Found By: --- Blocker: ---
When committing a large file to a remote build-service (eg. MeeGo) - it is -incredibly- slow.
here is the flow:
rm evolution-2.30.1~20100419.tar.bz2 cp .../evolution-2.30.1~20100423.tar.bz2 . osc addremove
osc commit < wait for 30+ seconds - it -looks- strongly form the strace as if we are up-loading or downloading something rather big here> finally get the commit editor:
[snip] --This line, and those below, will be ignored--
D evolution-2.30.1~20100419.tar.bz2 A evolution-2.30.1~20100423.tar.bz2
Diff for working copy: . Index: evolution-2.30.1~20100423.tar.bz2 ===================================================================
Binary file evolution-2.30.1~20100423.tar.bz2 has changed
Index: evolution-2.30.1~20100419.tar.bz2 ===================================================================
Binary file evolution-2.30.1~20100419.tar.bz2 has changed [/snip]
add a banal messsage - takes about 5 seconds. Then write the log & the up-load commences:
[snip] Deleting evolution-2.30.1~20100419.tar.bz2 Sending evolution-2.30.1~20100423.tar.bz2 Transmitting file data . < another wait of around 30 seconds - suspicious hey ! ;-> Committed revision 5. [/snip]
Can you confirm that we do not in fact do an up-load (or download) twice here ? presumably we shouldn't have to download anything to remove a file, and we can wait to up-load an added file until after the commit message is entered (surely?).
http://bugzilla.novell.com/show_bug.cgi?id=599186
http://bugzilla.novell.com/show_bug.cgi?id=599186#c
yang xiaoyu xyyang@novell.com changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |xyyang@novell.com AssignedTo|bnc-team-screening@forge.pr |adrian@novell.com |ovo.novell.com |
http://bugzilla.novell.com/show_bug.cgi?id=599186
http://bugzilla.novell.com/show_bug.cgi?id=599186#c1
Marcus Hüwe suse-tux@gmx.de changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |suse-tux@gmx.de
--- Comment #1 from Marcus Hüwe suse-tux@gmx.de 2010-04-26 12:05:09 UTC --- (In reply to comment #0)
Can you confirm that we do not in fact do an up-load (or download) twice here ? presumably we shouldn't have to download anything to remove a file, and we can wait to up-load an added file until after the commit message is entered (surely?).
Currently we re-download the deleted files in case you didn't specify a comment in order to create a diff. This re-downloading is due to a "misconception" in osc's working copy design (there might be cases where the storefile gets removed...). I'm currently thinking and working on a clean solution but it'll take some time...
https://bugzilla.novell.com/show_bug.cgi?id=599186
https://bugzilla.novell.com/show_bug.cgi?id=599186#c2
Marcus Hüwe suse-tux@gmx.de changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |RESOLVED Resolution| |FIXED
--- Comment #2 from Marcus Hüwe suse-tux@gmx.de 2010-08-31 17:07:02 UTC --- (In reply to comment #1)
Currently we re-download the deleted files in case you didn't specify a comment in order to create a diff. This re-downloading is due to a "misconception" in osc's working copy design (there might be cases where the storefile gets removed...). I'm currently thinking and working on a clean solution but it'll take some time...
This is fixed it in git master. So I think we can close this bug (if not please reopen).