Comment # 10 on bug 977027 from Andreas F�rber

(In reply to Michel Normand from comment #9)
> (In reply to Andreas F�rber from comment #8)
> > (In reply to Michal Suchanek from comment #7)
> > > SLOF is built from source so you can just add the patch in the qemu package
> > > spec as well.
> > 
> > In fact that is needed here. Please list which SLOF commits are needed for
> > cherry-picking to v2.7.0's submodule.
> 
> The required slof patch was already referenced in comment #4 of this bug.

Thanks for the pointer.

> Nevertheless it seems that qemu source tarball in OBS was previously updated
> with SLOF source tag between what is defined in github (tag
> qemu-slof-20121018) and the source files in roms/SLOF that match content of
> tag qemu-slof-20160223
> 
> So the maintainer in OBS Virtualization already previously accepted slof tag
> updates and not only one patch.

As maintainer, I certainly did not, because as I explained to you it would not
work. We take whatever SLOF code is in the official QEMU tarball on
qemu-project.org. We once applied local SLOF patches on top in our package.

(S/390 once had a temporary firmware update workaround in SLES11, therefore I
know our scripts don't handle such binary updates.)

Dinar previously requested that we replace SLOF with some newer version and
that request was rejected by our team. If other SLOF versions are desired for
testing, they need to be packaged separately, SRs to Virtualization or
Virtualization:Staging welcome.

Any patches for SLOF in qemu are maintained old-style (without Git queue), so
ultimately I need to make/get an SR with named .patch files being applied.

> This is the reason why I suggested the PR of comment #6
> 
> * the SLOF source code referenced in github openSUSE/qemu
>   is
> https://github.com/openSUSE/qemu/commit/
> 4fd50339c0b55fa6387fa3c28f755c306997064c
>   which is pointing to slof commit 0ad10f2:
>   https://github.com/aik/SLOF/releases/tag/qemu-slof-20121018
> 
> * in OBS Virtualization qemu the qemu-2.7.0.tar.bz2 is timestamped September
> 10th but there are no comment in qemu.changes what was the purpose of the
> change.
[snip]

I honestly don't understand what you're claiming here...

a) I already said on GitHub that master branch is the wrong branch. It is not
updated or used, so a 2012 tag is irrelevant. We are on opensuse-2.7 branch, as
can be seen in update_git.sh.

b) I personally downloaded the tarball from the official QEMU website and I am
certain you will find some "- Updated to v2.7.0" qemu.changes entry for that.
You should be able to verify the tarball with qemu-2.7.0.tar.bz2.sig that was
downloaded alongside the tarball. Whatever tags you find inside the tarball is
not my fault!

c) If there is something wrong with the upstream tarball you will need to
discuss that with the upstream QEMU maintainer, Peter Maydell.