What | Removed | Added |
---|---|---|
CC | fcrozat@suse.com | |
Flags | needinfo?(fcrozat@suse.com), needinfo?(rtsvetkov@suse.com) |
It's not YaST who sets the elevator, it's the user/customer. The point here is that our customers might depend (or rather think they depend) on it. YaST offers the UI to set that variable, customers use it and they don't get what they expected. There are obviously two options: 1. removal of the feature or 2. replacing with new functionality (how is an implementation detail). The current solution in /usr/lib/udev/rules.d/60-io-scheduler.rules LGTM, but I'm not the one to decide if that is enough to replace the old functionality. **Frederic, Rado: What do you think? Removal or new implementation?** The good part is that we do not offer that option via AutoYaST directly, but if customer has set this via additional kernel parameters for Bootloader https://github.com/yast/yast-bootloader/blob/master/src/autoyast-rnc/bootloader.rnc#L145 then we might need to do some more magic to, e.g., report some warning and remove that option. Some tests contain that value too https://github.com/yast/yast-bootloader/blob/78f31a9f30e42641c1147d199cac103aa1a4380f/test/data/grub.cfg#L137 Anyway, we can also check a bit more out of scope of YaST. Quick GitHub search, for instance says: https://github.com/SUSE/cluster-tools/blob/6a78ee1c86c75d2fc9fb289a5f31c85f8ae68c47/ClusterTools2-SLE12/sbin/cs_prepare_esxvm#L203 https://github.com/SUSE/sap-bootcamp/blob/90cca6a0e132c535a046fda84023a53c33c354bc/LandscapeCore/automate-VMs/automate-TODO-LATER-15-tune-sles-for-virt-and-hana#L79 ... there are more sap/cluster projects or branches and I'm unable to evaluiate them well ... Maybe https://github.com/SUSE/doc-slert/blob/3e117f3eb195cd6435750045eb9f7f9bce51ea7f/xml/art_slert_quickstart.xml#L1604 Maybe https://github.com/SUSE/doc-sle/blob/f59aee9f4eead38b58a3171943b1f35f73aff308/xml/vt_best_practices.xml#L808 Many places in docu were already adjusted, but I feel that some relevant pieces still mention elevator.