Comment # 4 on bug 1171128 from Quanah Gibson-Mount

(In reply to William Brown from comment #3)
> Given this information, I'm erring to retain the patch as it's presence is
> not harmful and there is no evidence that it causes issues or corruption.
> Even from a programming viewpoint, even if that variable were never access
> again, it is responsible defensive program to move the value to a state that
> prevents this kind of issue.

I discussed this patch with Howard yesterday. This issue would occur if some
other patch was made to OpenLDAP that was broken, causing incorrect behavior
for slapd at shutdown.

In other words, the only reason this patch would be necessary is because SuSE
applied a patch that incorrectly changes slapd behavior.

I would generally think it preferable to remove this patch and ensure that
slapd works as it is designed to do.  Perhaps the elimination of the known bad
patch from the build has resolved the problem.

I.e., it's important to know if this issue still occurs in SuSE builds, because
if it does, it indicates SuSE is continuing to apply broken patches to the
OpenLDAP software.