Comment # 16 on bug 1091864 from Simon Lees

(In reply to Marcus R�ckert from comment #15)
> (In reply to Simon Lees from comment #13)
> > (In reply to Fabian Vogt from comment #11)
> > > (In reply to Marcus R�ckert from comment #10)
> > > > I would still push for a shared make_jobs macro that works for both.
> > > 
> > > I fully agree - but currently the cmake-provided macro breaks Qt builds
> > > while the Qt-provided macro doesn't break cmake builds (ninja isn't used
> > > yet).
> > > 
> > > The %make_jobs macro implies that "make" is used any not "ninja", so IMO
> > > that macro needs to be renamed into %build_jobs or something else.
> > 
> > The macro has been renamed to %cmake_build in tumbleweed to be more
> > consistent
> 
> did you check how many packages that will break?
> 
> why not just use the version of the macro provided above which makes it work
> in all cases?

Personally I didn't make the change Tomas did, for now the macro has a fallback
mode and over the next couple of weeks he plans to go through and submit
updates to all the affected packages then remove the fallback once they are all
accepted into factory. His motivation wasn't fixing this issue but making the
cmake macro's function in the same way as the macros for other build systems.