Comment # 2 on bug 1198214 from Andrei Borzenkov

(In reply to andreas bittner from comment #0)
> and as of end of march 2022 even such red lines and details about:
> 
> firewalld[2914]: ERROR: Calling pre func <bound method
> Firewall.full_check_config of <class 'firewall.core.fw.Firewall'>(True,
> True, True, 'INIT', Fals>
> 

@meissner: DL;DR openSUSE-SLE-15.3-2022-1435 should be revoked.

May 02 08:26:33 leap15 firewalld[2159]: ERROR: Calling pre func <bound method
Firewall.full_check_config of <class 'firewall.core.fw.Firewall'>(True, True,
True, 'INIT', False, '', {}, [], True, True, True, True, 'all')>(()) failed:
check_config_dict() takes 2 positional arguments but 3 were given

The bug is due to patch
https://build.opensuse.org/package/view_file/openSUSE:Leap:15.3:Update/firewalld.23829/0001-chore-fw_zone-call-permanent-config-checks-at-runtim.patch?expand=1
which backported full_check_config() method, but calling convention of
check_config_dict() changed in the master.

bor@bor-Latitude-E5450:~/src/firewalld$ git grep check_config_dict v0.9.3
v0.9.3:src/firewall/core/io/io_object.py:    def check_config_dict(self, conf):

bor@bor-Latitude-E5450:~/src/firewalld$ git grep check_config_dict master
master:src/firewall/core/fw.py:               
io_obj.check_config_dict(io_obj.export_config_dict(), all_io_objects)
master:src/firewall/core/io/io_object.py:    def check_config_dict(self, conf,
all_io_objects):

The above patch calls "old" check_config_dict() with "new" calling conventions.

+            for (name, io_obj) in io_objs.items():
+                io_obj.check_config_dict(io_obj.export_config_dict(),
all_io_objects)