Joel Soete changed bug 1101735
What Removed Added
CC   Joel.Soete@skynet.be

Comment # 4 on bug 1101735 from
Hello all,

I also live a long time with this issue which mainly slowdown by kernel
updates.
But as I just finishing my upgrade OpenSUSE Leap 15.2 to 15.3, I try again to
understand...

Before finding out this thread, I also finally discover this (infamous)
OS_PROBER_DISABLE_DEBUG env var which apparently just have to be set something
not an empty string:
/usr/share/os-prober/common.sh
[...]
debug() {
  if [ -z "$OS_PROBER_DISABLE_DEBUG" ]; then
    log "debug: $@"
  fi
}
[...]

Also I tried also to edit my /etc/default/grub and setup this var:
[...]
OS_PROBER_DISABLE_DEBUG="true"
[...]

But no success :(.
Also I simply trace this debug() function to figure out that whatever can be
the content of this var, the test result is always true :(.
So it seems that /usr/share/os-prober/common.sh don't know the
OS_PROBER_DISABLE_DEBUG value setup in /etc/default/grub?

I so try to export is :
e.g. export OS_PROBER_DISABLE_DEBUG="true" 
and that make the drill :)

At least that stay in a config file related to grub, no?
What's your opinion?

That said I just find it infamous because debugging function is active by
default?
Wouldn't it be better that we activate when we encountered an issue?

A simple proposal would be:
--- /usr/share/os-prober/common.sh.orig    2021-07-21 15:29:32.970807080 +0000
+++ /usr/share/os-prober/common.sh    2021-07-21 15:27:53.607474229 +0000
@@ -66,7 +66,7 @@
 }

 debug() {
-  if [ -z "$OS_PROBER_DISABLE_DEBUG" ]; then
+  if [ -n "$OS_PROBER_DEBUG" ]; then
     log "debug: $@"
   fi
 }

and obviously 
export OS_PROBER_DEBUG="true"
in /etc/default/grub will revert to debugging logs ;)

Just 2 pence idea


You are receiving this mail because: