Comment # 28 on bug 1043231 from Benjamin Poirier

(In reply to Takashi Iwai from comment #21)
[...]
> > 0007-ACPI-bus-add-stub-acpi_evaluate_dsm-to-linux-acpi.h.patch
> > 0008-ACPI-bus-add-stub-acpi_dev_found-to-linux-acpi.h.patch

6eb17e0df74c ACPI: bus: add stub acpi_dev_found() to linux/acpi.h (v4.8-rc1)
4ae399241adb ACPI: bus: add stub acpi_evaluate_dsm() to linux/acpi.h (v4.8-rc1)

> > 
> > These are required to fix:
> > 
> > /home/matwey/lab/linux/drivers/net/ethernet/hisilicon/hns/hns_dsaf_main.c:
> > In function 'hns_dsaf_get_cfg':
> > /home/matwey/lab/linux/drivers/net/ethernet/hisilicon/hns/hns_dsaf_main.c:64:
> > 7: error: implicit declaration of function 'acpi_dev_found'
> > [-Werror=implicit-function-declaration]
> >    if (acpi_dev_found(hns_dsaf_acpi_match[0].id))
> > 
> > So, actually it is SUSE kernel patch net-hns-dsaf-adds-support-of-acpi.patch
> > which breaks hisilicon compilation for armv7l.
> > I think there could be three options 1) accepting ACPI-* patches 2) fixing
> > net-hns-dsaf-adds-support-of-acpi.patch,
> > net-hns-net-hns-enet-adds-support-of-acpi.patch,
> > net-hns-Add-ACPI-support-to-check-SFP-present.patch and
> > net-hns-implement-the-miscellaneous-operation-by-asl.patch in order no to

8413b3be4d77 net: hns: dsaf adds support of acpi (v4.8-rc1)
f00ef863da2b net: hns: implement the miscellaneous operation by asl (v4.8-rc1)
63434888aaf1 net: hns: net: hns: enet adds support of acpi (v4.8-rc1)
b917078c1c10 net: hns: Add ACPI support to check SFP present (v4.11-rc6)

> > use acpi_dev_found() and acpi_evaluate_dsm() functions at armv7l 3) disable
> > NET_VENDOR_HISILICON_HNS in config and not to build this code.
> > What would you prefer?
> 
> I put Benjamin to Cc.
>
> But I guess these two are fine from the kABI POV, too, as they just add
> dummy static inline functions.

I think you're right. The two ACPI commits are part of the same series as the
first three hns commits so they should all have been added at the same time.

That series was merged in b1c6a3a46b8b ("Merge branch 'hns-acpi'", v4.8-rc1)