Petr Gajdos changed bug 1062808
What Removed Added
Flags   needinfo?(astieger@suse.com)

Comment # 14 on bug 1062808 from
(In reply to Andreas Stieger from comment #13)
> (In reply to Petr Gajdos from comment #12)
> > Maintenance: could we provide new package, gkrellm-cpupower meant as a
> > replacement for gkrellm-cpufreq (for 42.3)?
> 
> We would rather not, zypper in not really capable of replacing packages that
> are not otherwise required. 

gkrellm-cpufreq does not work at all. What about just add gkrellm-cpupower
which does not fileconflict with gkrellm-cpufreq to update channels? And we can
release gkrellm-cpufreq just with README.SUSE that it does not work and perhaps
even Require gkrellm-cpupower from that package.

> Please check kernel changes:
> https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/
> tools/power/cpupower/lib?id=ac5a181
> 
> Especially if cpufreq_cpu_exists needs to be replaced with
> cpupower_is_cpu_online.

This was first I tried. Unfortunately cpupower_is_cpu_online is private:

cpupower-4.11[1]> find -name *.h -exec grep cpupower_is_cpu_online {} +
./lib/cpupower.h:int cpupower_is_cpu_online(unsigned int cpu);
cpupower-4.11[1]>

$ rpm -ql cpupower-devel | grep '\.h'
/usr/include/cpufreq.h
/usr/include/cpuidle.h
$

And, as you know, 'our' gkrellm-cpufreq is hacked to use cpupower anyway, I
think much better is to use new upstream version to find bugs etc, you know,
open source.


You are receiving this mail because: