Michal Kube��ek changed bug 1051364
What Removed Added
Status NEW RESOLVED
CC   mkubecek@suse.com
Resolution --- DUPLICATE
Assignee kernel-maintainers@forge.provo.novell.com mkubecek@suse.com

Comment # 4 on bug 1051364 from
You can drop the line updating dev->last_rx unconditionally as that's what
should have been done by Realtek long time ago. See Bug 1035734 comment 4
for explanation.

Strictly speaking, comparing the version with 4.4.76 isn't correct as that
would omit the update for kernels 4.5 through 4.10 which still have last_rx in
struct net_device. On the other hand, as explained in the comment referenced
above, there is no need to update last_rx since 2.6.29 so if you want the
driver to work with old kernels, you should use 2.6.29 for version check.

> make[1]: Entering directory '/usr/src/linux-4.4.76-1-obj/x86_64/default'
>   CC [M]  /usr/src/r8168-8.040.00/r8168_n.o
> /usr/src/r8168-8.040.00/r8168_n.c: In function 'rtl8168_start_xmit':
> /usr/src/r8168-8.040.00/r8168_n.c:24562:12: error: 'struct net_device' has no member named 'trans_start'
>          dev->trans_start = jiffies;

Version 8.044.02 currently available at the location provided in comment 2
already has the update of trans_start ifdef-ed to be only compiled for kernels
older than 3.5 so I assume this has been fixed between 8.040.00 and 8.044.02.

In any case, this is a problem of the out-of-tree driver, not a bug in the
openSUSE 42.3 kernel.

*** This bug has been marked as a duplicate of bug 1035734 ***


You are receiving this mail because: