What | Removed | Added |
---|---|---|
CC | bpoirier@suse.com |
(In reply to Matwey Kornilov from comment #20) > 0001-ARM-EXYNOS-Remove-calls-to-of_genpd_get_from_provide.patch is > 0002-mvebu-Use-dev_pm_opp_set_sharing_cpus-to-mark-OPP-ta.patch is > 0003-cpufreq-tegra124-No-need-of-setting-platform-data.patch is They are fine. > 0004-extcon-adc-jack-Remove-the-usage-of-extcon_set_state.patch > 0005-extcon-arizona-Remove-the-usage-of-extcon_update_sta.patch OK, these aren't used for x86, so it's no big problem about kABI change for now. > 0006-input-misc-max77693-Use-pwm_get_args-where-appropria.patch Ditto. > 0007-ACPI-bus-add-stub-acpi_evaluate_dsm-to-linux-acpi.h.patch > 0008-ACPI-bus-add-stub-acpi_dev_found-to-linux-acpi.h.patch > > These are required to fix: > > /home/matwey/lab/linux/drivers/net/ethernet/hisilicon/hns/hns_dsaf_main.c: > In function 'hns_dsaf_get_cfg': > /home/matwey/lab/linux/drivers/net/ethernet/hisilicon/hns/hns_dsaf_main.c:64: > 7: error: implicit declaration of function 'acpi_dev_found' > [-Werror=implicit-function-declaration] > if (acpi_dev_found(hns_dsaf_acpi_match[0].id)) > > So, actually it is SUSE kernel patch net-hns-dsaf-adds-support-of-acpi.patch > which breaks hisilicon compilation for armv7l. > I think there could be three options 1) accepting ACPI-* patches 2) fixing > net-hns-dsaf-adds-support-of-acpi.patch, > net-hns-net-hns-enet-adds-support-of-acpi.patch, > net-hns-Add-ACPI-support-to-check-SFP-present.patch and > net-hns-implement-the-miscellaneous-operation-by-asl.patch in order no to > use acpi_dev_found() and acpi_evaluate_dsm() functions at armv7l 3) disable > NET_VENDOR_HISILICON_HNS in config and not to build this code. > What would you prefer? I put Benjamin to Cc. But I guess these two are fine from the kABI POV, too, as they just add dummy static inline functions. So far, so good. I'll try to apply these ones. Let's check the rest.