Comment # 45 on bug 1165780 from
(In reply to Karl Mistelberger from comment #44)
> (In reply to Fabian Vogt from comment #42)
> > (In reply to Franck Bui from comment #41)
> > > The change doesn't seem to be available in TW, anything wrong happened ?
> > 
> > The sr got declined: https://build.opensuse.org/request/show/823587
> > 
> > For reference, this is my comment which lead to the decline:
> > 
> > > Deleting the [Install] section is a noop, it will only break later calls to "systemctl enable btrfsmaintenance-refresh.service". Existing systems will not be impacted by that. In fact, the removal of After=local-fs.target might even break it.
> > >
> > > Is that intentional?
> > >
> > > I recommend updating systemd-presets-common-SUSE instead to not explicitly enable btrfsmaintenance-refresh.service.
> > 
> > To double check, I just updated btrfsmaintenance to the 0.5 version from the
> > devel prj in a VM and btrfsmaintenance-refresh.service still runs on boot as
> > the .service file is still linked to
> > /etc/systemd/system/multi-user.target.wants/.
> 
> btrfsmaintenance-refresh.service was NEVER INTENDED to be enabled or
> installed.
> 
> btrfsmaintenance-refresh.path triggers btrfsmaintenance-refresh.service upon
> changes of /etc/sysconfig/btrfsmaintenance

Yes, that is so far correct. The issue is, it IS enabled as that's what
previous
versions did and so on existing systems it STAYS enabled because removing the
[Install] section does not run a call to systemctl disable.

As long as the service is still enabled in the preset, it will stay enabled.
It might be enough to remove it from
https://build.opensuse.org/package/view_file/Base:System/systemd-presets-common-SUSE/default-SUSE.preset?expand=1&rev=29
(line 12), but I'd add a systemctl disable call in %post to be sure, in case
someone enabled it manually.


You are receiving this mail because: