| What | Removed | Added |
|---|---|---|
| Flags | needinfo?(fvogt@suse.com) |
(In reply to Thomas Blume from comment #11) > Can you please give the dracut package at: > > https://build.opensuse.org/package/binaries/home:tsaupe:branches:openSUSE: > Factory:dracut-bsc1173402/dracut/openSUSE_Factory > > a try? Works! Looking at this again, this is quite the mess... AFAICT, touching the did-setup file after a successful "do_dhcp" is generally the right way. This is currently not done, which lead to https://github.com/tblume/dracut/commit/0b998beebc008f2dda2eed8a36d59f4a258cb27a adding another path to create did-setup. This new path was broken by https://github.com/tblume/dracut/commit/28be2f3692d6a641c841f636c03e45c5f3c4ec6b, which you now fixed with https://github.com/tblume/dracut/commit/487fb167b82c88871e6d1ace21ccdb0a48e9032d. What should be done IMO: - Touch did-setup in the "# No ip lines default to dhcp" case after successful do_dhcp - Touch did-setup in the "# no ip option directed at our interface?" case after successful do_dhcp 0b998beebc008f2dda2eed8a36d59f4a258cb27a introduced the code to handle the latter, but: - It also runs in cases where the do_dhcp in this block wasn't actually run (like in this bug report) - The $? it checks is meaningless at this point due to the ifs In the "rd.neednet=1 bootdev=eth0" case it actually runs do_dhcp twice for the interface, as both "# No ip ..." blocks apply. Maybe those blocks should be merged?