Bug ID | 1226118 |
---|---|
Summary | Salt "The django returner is broken and deprecated, and will be removed after 2024-01-01" |
Classification | openSUSE |
Product | openSUSE Distribution |
Version | Leap 15.5 |
Hardware | Other |
OS | openSUSE Leap 15.5 |
Status | NEW |
Severity | Normal |
Priority | P5 - None |
Component | Salt |
Assignee | salt-maintainers@suse.de |
Reporter | georg.pfuetzenreuter@suse.com |
QA Contact | qa-bugs@suse.de |
Target Milestone | --- |
Found By | --- |
Blocker | --- |
Hi, setting ``` master_job_cache: redis job_cache_store_endtime: True ``` in the master configuration causes some runner commands to return: ``` salt-run mine.get witch1.infra.opensuse.org roles [ERROR ] Exception raised when processing __virtual__ function for salt.loaded.int.returner.django_return. Module will not be loaded: The django returner is broken and deprecated, and will be removed after 2024-01-01. This warning(now exception) triggered on filename '/usr/lib/python3.6/site-packages/salt/returners/django_return.py', line number 61, is supposed to be shown until 2024-01-01. Today is 2024-06-09. Please remove the warning. [WARNING ] salt.loaded.int.returner.django_return.__virtual__() is wrongly returning `None`. It should either return `True`, `False` or a new name. If you're the developer of the module 'django_return', please fix this. witch1.infra.opensuse.org: # expected mine results show up ``` ``` $ rpm -q salt-master salt-master-3006.0-150500.4.35.1.x86_64 ``` Hotpatch is changing `20240101` to `20250101` in `/usr/lib/python3.6/site-packages/salt/returners/django_return.py`. Upstream no longer ship the Django returner at all, but the patch removing it is rather big: https://github.com/saltstack/salt/commit/3b24505b3a344cf6a0fa16428090e8ad742c5fe8. Not sure if that is feasible to backport or too breaking of a change. Best, Georg