Comment # 39 on bug 1183247 from Eric van Blokland

(In reply to Michal Koutn��� from comment #37)
> (In reply to Eric van Blokland from comment #36)
> > Your patch does not work out of the box. It fails in virCgroupV2BindMount
> > when it tries to create the directory (g_mkdir_with_parents)
> > "/sys/fs/cgroup/unified". 
> 
> Thanks for the test!
> 
> > That may seem a bit dirty, but to me it's less convoluted than letting V2 be
> > aware it should be mounted within V1.
> 
> It relies on the tmpfs mount over the ro-path in the v1 virCgroupBindMount,
> yeah, that's slightly dirty but nothing incorrectable (should be explained
> in the commit message though).
> 

If you have any suggestions on how to improve that, let me know. I recall "do"
loops are frowned upon these days, but I wanted to make explicit this loop was
doing something else than the others, without messing with types. In any case
I'll mention it more explicitly in the commit message.

> > I've tested this patch with hybrid and unified cgroups, but not without
> > systemd.
> 
> Would you send the patch (even the current form) to the upstream [1]? (To
> resolve the nuances there.) I can help you if you're unfamiliar; if you send
> yourself, please Cc me on that mail.
> 
> [1] https://libvirt.org/submitting-patches.html

You guessed correctly that I'm not familiar with mailing patches around, but I
think I'll manage. I've got time tomorrow in the afternoon to tidy things up.
I'll let you know if I get stuck somewhere.

I'll also be sure to cc you and mention the report in the libvirt gitlab.