Comment # 10 on bug 1157462 from Dr. Werner Fink

(In reply to Simon Lees from comment #9)
> (In reply to Dr. Werner Fink from comment #8)
> > SR#752324 -- could one have a review? Other than me!
> 
> Sorry due to timezones I was done for Friday when you sent this, doing the
> update was on my today list if I hadn't heard a good reason to keep
> --enable-asserts. 
> 
> I this using --disable-asserts would be better then adding another patch,
> its also now how debian handle it.
> https://salsa.debian.org/utopia-team/dbus/blob/debian/master/debian/rules

The udeb_configure_flags rule with --disable-asserts  is used for the udeb
packages and those type of packages are only for internal build system for
debian packages.

The patch is also from debian (not utopia!) and is really simple: do not debug
within a running system (no exit(3) nor abort(3) in system libraries):

 --- a/dbus/dbus-internals.c
 +++ b/dbus/dbus-internals.c
 @@ -185,7 +185,7 @@ const char *_dbus_no_memory_message = "Not enough memory";

  static dbus_bool_t warn_initted = FALSE;
  static dbus_bool_t fatal_warnings = FALSE;
 -static dbus_bool_t fatal_warnings_on_check_failed = TRUE;
 +static dbus_bool_t fatal_warnings_on_check_failed = FALSE;

  static void
  init_warnings(void)

could you please explain what is wrong with this approach? If you like to debug
you are able to set the environment variable DBUS_FATAL_WARNINGS to 1.
Currently we do not set DBUS_FATAL_WARNINGS at all, that is with the current
default all customers and users out there do debugging their systems and do not
know about nor can handle this.  This causes a lot of trouble and bugzilla
entries.