Comment # 12 on bug 1148809 from Adam Spiers

(In reply to Michael Chang from comment #11)
> (In reply to Adam Spiers from comment #10)
> > (In reply to Michael Chang from comment #8)
> > > (In reply to Adam Spiers from comment #7)
> > > > With your test package grub2-editenv runs fine with exit code 0 (although
> > > > the fd leakage is still there).
> > > 
> > > The fd leakage should be harmless,
> > 
> > Let's call it "*mostly* harmless" ;-)  Any unnecessary pollution of log
> > files makes true errors harder to spot, therefore it is still harmful to a
> > small extent.
> 
> It may need the assist from YaST team to diagnose the leak, as it turns out
> all parents to the vgs sub-process are suspicious. I'd suggest to open
> another bug report for tracking if you think it worth to do so.

OK, submitted as bug #1151960.

> > No, the original problem is that libstorage-ng can't correctly recognise
> > cached LVs since the first byte of their lv_attr is 'C', so it gives them
> > LvType::UNKNOWN and then fails to detect the filesystem.  This is explained
> > in detail in the original report at the top of
> > https://github.com/openSUSE/libstorage-ng/issues/664
> > 
> > I have proposed a simple fix in my latest comment there.
> 
> Thanks a lot for your information. I am going to submit it as the patch
> seems harmless to other scenarios and we can move forward. Also a copy to
> upstream for comments.

That's great, thanks!  I'm happy to test any package you build with the patch.