Comment # 7 on bug 1190823 from Hans-Peter Jansen

Dear Dominique & gang,

(In reply to Dominique Leuenberger from comment #6)
> We (Fabian and I) debugged this a bit more, and found
> 
> * The build has ffmpeg enabled
> * openh264 disabled (not available in the distro)

The question is, why is it missing? From https://github.com/cisco/openh264, it
appears as a usual BSD-2-Clause licenced package, and it seems to be maintained
as well.

I do build freerdp since long with it included.

> The openSUSE ffmpeg flavor is without h264 (no license)
> 
> in this constellation, though, freerdp expects h264 to be provided through
> ffmpeg and fails if this is not the case.

I already fiddled with ffmpeg h264 support in the form of x264, because such a
compile option existed. Unfortunately, there was no code "behind", hence I
pushed a change to remove this option completely. But I could be missing
something.

> Optimally, freerdp would do a runtime detection on ffmpeg to see if h264 is
> really available (it could/would be if packman or VLC was enabled) and only
> use it in this case, and do the fallback as if ffmpeg was not available.
> 
> 2nd best option would be to disable ffmpeg support in freerdp completely,
> and force the fallback

Let's try to address my first question first, and if there's a valid reason for
not including it, I will get in touch with the upstream project in this regard.

Deal?