Jiri Slaby changed bug 1141444
What Removed Added
Attachment #810435 is obsolete   1

Comment # 14 on bug 1141444 from
Created attachment 811251 [details]
clementine ran with valgrind --leak-check=full

(In reply to Jonas Kvinge from comment #12)
> I don't understand what all the QList<QPair<QString, QString> leaks are
> about.

Better to look into the valgrind report, not the ASAN's. They are
UltimateLyricsReader leaks:

> 992 bytes in 31 blocks are possibly lost in loss record 11,742 of 12,222
>    at 0x483677F: malloc (in /usr/lib64/valgrind/vgpreload_memcheck-amd64-linux.so)
>    by 0x4F5123F: QListData::detach_grow(int*, int) (qlist.cpp:96)
>    by 0x67C2C5: UnknownInlinedFun (qlist.h:775)
>    by 0x67C2C5: QList<QList<QPair<QString, QString> > >::append(QList<QPair<QString, QString> > const&) (qlist.h:601)
>    by 0x67C682: UnknownInlinedFun (qlist.h:404)
>    by 0x67C682: UnknownInlinedFun (ultimatelyricsprovider.h:52)
>    by 0x67C682: UltimateLyricsReader::ParseProvider(QXmlStreamReader*) const (ultimatelyricsreader.cpp:79)
>    by 0x67C9C2: UltimateLyricsReader::ParseDevice(QIODevice*) const (ultimatelyricsreader.cpp:51)
>    by 0x67CB0D: UltimateLyricsReader::Parse(QString const&) const (ultimatelyricsreader.cpp:39)
>    by 0x67CF68: non-virtual thunk to QtConcurrent::RunFunctionTask<QList<SongInfoProvider*> >::run() (qtconcurrentrunbase.h:119)
>    by 0x4EFF431: QThreadPoolThread::run() (qthreadpool.cpp:99)
>    by 0x4EFC111: QThreadPrivate::start(void*) (qthread_unix.cpp:360)
>    by 0x78D8FA9: start_thread (pthread_create.c:486)
>    by 0x568373E: clone (clone.S:95)

I am not sure if UltimateLyricsReader is ever deleted. Note it looks to be
allocated with every song change. Also, even if it was released, I don't know,
if it would delete the parser data. (I don't have time to look into it.)


You are receiving this mail because: