What | Removed | Added |
---|---|---|
Status | NEW | RESOLVED |
Resolution | --- | UPSTREAM |
Summary | Korganizer does not display holidays | Korganizer does not display Israel's holidays |
Flags | needinfo?(eliwap@gmail.com) |
(In reply to Eli Wapniarski from comment #6) > grep Holidays ~/.config/korganizerrc > Exclude Holidays=false > > produces > Holidays=il_en-us Ok, so the setting is being saved correctly. (there was a bug about this, but this should be fixed since 5.3.0) I can reproduce the problem now though. > Just a side note... While the file for Canada (French) is included in the > rpm. There is no listing for it in the Holidays drop down. It is listed as "Quebec (French)". > So it would seem that there is a problem with the Israel holidays in the > library The holidays data files should be fine, they haven't been changed since 2014. The problem rather seems to be that there is no support for the Hebrew calendar system implemented. So apparently this is just another case of the "broken"/inappropriate locale support in Qt5 (and KDE dropped their own in favor of Qt's). Though to be fair, kholidays contains/uses its own QCalendarSystem class (apparently intended to be included in Qt itself at some point), which is "incomplete" obviously. Nothing we (openSUSE) as a distribution can really do about that, sorry. FWIW, I filed an upstream bug report though: https://bugs.kde.org/show_bug.cgi?id=383896 (Interesting that there wasn't one already...) Btw, the "Victory Day" is actually displayed (it's specified as "cultural on gregorian may 9"), but only if it is on a weekday outside the "Working Period" (i.e. Saturday or Sunday by default). Looks like another, independent, bug to me. (seems to happen with all holidays except "civil" ones)