James Fehlig changed bug 1203562
What Removed Added
CC   aginies@suse.com
Flags   needinfo?(aginies@suse.com)

Comment # 3 on bug 1203562 from
(In reply to James Fehlig from comment #2)
> I would close this as invalid, but it is probably worth backporting commit
> de2a338dce to the libvirt 8.0.0 package for the improved error handling.

After spending 1 day now trying to backport this patch I'm wondering if the
effort is worth it. Since the RH guys have nothing to do except rewrite code,
even a simple commit like de2a338dce is difficult to backport. I've already
added commits 29bbd927 and f5dcd8b9 to ease the pain, but still failing lots of
unit tests. If we really want this fixed up right, we'd probably need all the
commits touching the firmware handling code

c76e595131abeff6ce1ddcd0047decf71ddd5267
031f379573a28c7784096825f4975956495f0974
acb8733924e2f330e3774de9ab21fc2eee3534fb
f29a8bcef1dd9bdeb1b2819dd73b8e94cd833634
53cdfd7994a5c3352ec9a998a8fb003a008b91ac
2ce1dcc6b57426009fe4841ad41c2c03112391fc
29bbd927f8fd248856a4957f7e9ce84f71423c3e
1afc026c73c7514c5e95b12d06aca18a0bfa6e26
628c018344688505db0d67f1389144ab14ee88a8
040ebb9d1b5d1817ab41c446303ee12d157abda6
cec35f4a5225d9188a6c201d03531cb9562dabfe
5943e4ade6dd10c5c65a195234eff3742c7e7221
28c689dc61bc1e24fb2e03a6d445ea1a7a938d28
f0e68d28e1ef182a5f0e2bf4666fcbb14b06a44d
bdd9ce0fda75d9c79c153912fc964c8f1aed1aae
9c7499ce542e296ebbcb28db7da6582c85cba176
6cacfc751eb4d200da78a0a59de0676478e8a33b
c98910d0110850ffcf3e534b5ea70a3afabb53f9
161b31f9584eeba17cf29d38289c3a8a03e9e858
421d4f1fa84529f9c7c5d884e09ec42a71d737f0
f5dcd8b9796f7dacb9e91da17099d39c5622e328
de2a338dcebde096d4806e43702513284607db8f
c4b8124e45ae754e7432a9065a1e4a54bbd971e6
73c5ae55c7c3a5b26cc16ad85ecd57fc1d410b33
262672dbbfe46c6e9090afdf516c13bfb93f98e5
981879d026d9ee89183125d0049191097ec10b47
578ac25c6ae86d3f655ad902d1bcb57beff0e936
ef53798ab645496002aa8da2b3650dde19832f3d

Or just wait for all this stuff in SP5. Antoine, would you like me to continue
with this and backport all these firmware handling improvements to SP4?


You are receiving this mail because: