Ivan Topolsky changed bug 965477
What Removed Added
CC   ivan.topolsky@isb-sib.ch

Comment # 8 on bug 965477 from
Created attachment 665807 [details]
Missing "return 0"

> The offending line being line 87 in module_setup.sh: 
> 
> running_in_qemu && hostonly='' instmods virtio_net e1000 8139cp pcnet32 e100
> ne2k_pci
> 
> running_in_qemu returns 255 and that makes dracut fail.
> 
> Commenting out this line allows the generation of the initrd.

There's a missing "return 0" (=success) statement at the end of the function.

Otherwise the function inherits the return status of the last executed
statement.

In our case - mine and Luca's - we don't run openSuSE Tumbleweed under qemu.
So "running_in_qemu" correctly returns 255 as it should (= false)

But then "installkernel()" reaches end, while nothing change the return status
(Still 255, thus dracut considers it as a failure).

If no error happened, status should be 0, hence my patch.


You are receiving this mail because: