Comment # 17 on bug 904524 from
(In reply to Karl Ove Hufthammer from comment #16)
> Note that this would only fix part of the problem with translations being
> stripped from .desktop.

Yes. It's a port of KDE4's (and KDE3's) patch that reads those translated
entries from desktop_translations.mo if they are not found in the .desktop
file.
This brings KF5 in line with KDE4 regarding this.

It doesn't fix anything (yet) in regards to the originally reported problem
here.

> Various KDE applications use the translations stored
> in .desktop files for *various* purposes, and all these applications must
> also be patched for all translations to work properly. For an example, see:
> https://techbase.kde.org/Development/Tutorials/Localization/
> i18n_Challenges#Translating_Data
> (The corresponding openSUSE package is ���jovi���.)
> Another example is the names (i.e. descriptions) of wallpapers in KDE.

This should work none-the-less for all translated "Name", "GenericName", and
"Comment" entries.
They are just taken from openSUSE's desktop_translations.mo (where they get
added after they are stripped out of the .desktop file) then, if they are not
present in the .desktop file.

The patch modifies KDE Frameworks' functions that are used by (KDE)
applications to get those translated entries in the first place, so should be
transparent to all applications.

I agree with you though that it's probably not a good idea to unconditionally
strip *all* .desktop files in /usr/share/ (see comment#9), that's what caused
this bug report in the first place.
This was changed here btw:
https://build.opensuse.org/request/show/239135
(before that change, only .desktop files in selected directories were stripped)

> *if* it���s really the case that openSUSE people really don���t trust the part of > the official KDE translations that happens to be stored in .desktop files
> instead of .po files, and must supply their own translations

This is not only about KDE, but *all* .desktop files included in the
distribution (well, most at least, KDE3's are not stripped any more since that
change as they are in /opt/kde3/).
If we would leave out this patch in KDE and even not strip the .desktop files,
GNOME applications (and others) would still be untranslated in KDE's
application menu.


You are receiving this mail because: