What | Removed | Added |
---|---|---|
Flags | needinfo?(tittiatcoke@gmail.com) |
Hrm, you caught: commit 54a3120e339e55fc4721543abb15692c3e9ede09 Author: Peter De Wachter <pdewacht@gmail.com> Date: Wed Mar 20 00:35:45 2013 +0100 Map REL_DIAL to vertical scrolling did you also see: commit 41cf9212d02c1d2adca0e85702a1f0faba9e6b37 Author: Peter Hutterer <peter.hutterer@who-t.net> Date: Mon Apr 28 12:23:18 2014 +1000 Map REL_DIAL to horizontal scrolling (#73105) ? It begs the question if we want this change or not as it changes the behaviour of a relative dial. Since upstream has settled to mapping this to horizontal scrolling a long time ago and has restored this since, it is better to fix this now than later. In principle I don't mind the patches. However your SR doesn't adhere to our standards, therefore if we want to bring this into SLE12 we have to do the work over again. It would be nice if you do the 2 steps: 1. introduce the unpatched package from SLE12 into openSUSE:42. 2. Add all patches from upstream individually. There are guidelines for the format: https://en.opensuse.org/openSUSE%3aPatches_Guidelines_for_X11%3aXOrg_Project I've got a script I can give to you to generate them which I can give to you. You can of course combine patches in a single changelog entry. (The 4th patch should probably be added separately). If you prepare 1 for me, I'd be happy to help out with 2.