Bug ID | 1117483 |
---|---|
Summary | openvswitch: please consider dropping the use of DISABLE_STOP_ON_REMOVAL/DISABLE_RESTART_ON_UPDATE |
Classification | openSUSE |
Product | openSUSE Tumbleweed |
Version | Current |
Hardware | Other |
OS | Other |
Status | NEW |
Severity | Normal |
Priority | P5 - None |
Component | Network |
Assignee | bnc-team-screening@forge.provo.novell.com |
Reporter | fbui@suse.com |
QA Contact | qa-bugs@suse.de |
Found By | --- |
Blocker | --- |
Hi Jaime, After a discussion with Markos, it appears that the use of both DISABLE_STOP_ON_REMOVAL=yes and DISABLE_RESTART_ON_UPDATE=yes in openvswitch.spec is not needed at all. Regarding DISABLE_RESTART_ON_UPDATE=yes and according to Markos, OVS services can now be restarted on package updates because "it's being handled by the upper layers from crowbar or whatever else management tool they use". Even if the package would still need to be restarted on updates, %systemd_postun_with_restart() or %systemd_postun() macros should be used instead of the env variable. Regarding DISABLE_STOP_ON_REMOVAL=yes: this was actually an "addon" on the previous issue but it's not needed at all. It would be nice if it could be dropped especially since a) leaving a daemon running while all its files (binaries, libs, config files, etc...) have been deleted may obviously lead to crashes b) one can expect that the network is going down if a package such as openvswitch is removed. Thanks.