Comment # 23 on bug 1141883 from
(In reply to Andre Heinecke from comment #22)
> Created attachment 811595 [details]
> 0001-qt-Fix-use-of-dangling-pointer.patch
> 
> Hi,
> 
> Thank you very much for your work analyzing this and providing a patch. Good
> catch.
> 
> Due to:
> 
> Note: argc and argv might be changed as Qt removes command line arguments
> that it recognizes.
> 
> I've changed the patch a bit so that it still uses a copy of argc but that
> variable is now in the main scope, because we do not want Qt to remove
> options that it recognizes. E.g. Display. before we do our own option
> parsing in pinentry_parse_opts. That was the reason behind the "i = argc".
> 
> Patch applied as rev. 0e2e53c8987d6f236aaef515eb005e8e86397fbc

LGTM, thanks!


You are receiving this mail because: