Comment # 4 on bug 1206756 from
This package integrates the `iodine` IPv4-over-DNS client with NetworkManager.
It is comprised of two parts, a GTK UI and a D-Bus service. Both are only
accessible with root credentials.

The D-Bus service `nm-iodine-service` runs under a separate system user account
(`nm-iodine`) without any special privileges, no shell and no home directory.
The service itself is written in glib-style C, of decent quality, in less than
1 kLOC.  It interacts with the iodine binary, executing it asynchronously and
parsing its output.  Subprocess execution is performed with a proper
argv-array. Its output is parsed with low level string manipulation with
sufficient checks and range-checked glib functions.

All good, as far as I can see. The underlying `iodine` package might be a
different matter but that's outside the scope of this review.

I will proceed with the whitelisting.


You are receiving this mail because: