Bug ID 1232983
Summary VUL-0: CVE-2024-51744: forgejo: github.com/golang-jwt/jwt/v4: Bad documentation of error handling in ParseWithClaims can lead to potentially dangerous situations in golang-jwt
Classification openSUSE
Product openSUSE Distribution
Version Leap 15.5
Hardware Other
URL https://smash.suse.de/issue/426863/
OS Other
Status NEW
Whiteboard CVSSv3.1:SUSE:CVE-2024-51744:3.1:(AV:N/AC:H/PR:N/UI:R/S:U/C:L/I:N/A:N)
Severity Normal
Priority P5 - None
Component Security
Assignee security-team@suse.de
Reporter andrea.mattiazzo@suse.com
QA Contact security-team@suse.de
Blocks 1232936
Target Milestone ---
Found By ---
Blocker ---

golang-jwt is a Go implementation of JSON Web Tokens. Unclear documentation of
the error behavior in `ParseWithClaims` can lead to situation where users are
potentially not checking errors in the way they should be. Especially, if a
token is both expired and invalid, the errors returned by `ParseWithClaims`
return both error codes. If users only check for the `jwt.ErrTokenExpired `
using `error.Is`, they will ignore the embedded `jwt.ErrTokenSignatureInvalid`
and thus potentially accept invalid tokens. A fix has been back-ported with the
error handling logic from the `v5` branch to the `v4` branch. In this logic,
the `ParseWithClaims` function will immediately return in "dangerous"
situations (e.g., an invalid signature), limiting the combined errors only to
situations where the signature is valid, but further validation failed (e.g.,
if the signature is valid, but is expired AND has the wrong audience). This fix
is part of the 4.5.1 release. We are aware that this changes the behaviour of
an established function and is not 100 % backwards compatible, so updating to
4.5.1 might break your code. In case you cannot update to 4.5.0, please make
sure that you are properly checking for all errors ("dangerous" ones first), so
that you are not running in the case detailed above.

References:
http://web.nvd.nist.gov/view/vuln/detail?vulnId=CVE-2024-51744
https://www.cve.org/CVERecord?id=CVE-2024-51744
https://github.com/golang-jwt/jwt/commit/7b1c1c00a171c6c79bbdb40e4ce7d197060c1c2c
https://github.com/golang-jwt/jwt/security/advisories/GHSA-29wx-vh33-7x7r
https://bugzilla.redhat.com/show_bug.cgi?id=2323735


You are receiving this mail because: