Mailinglist Archive: zypp-devel (26 mails)

[Michael Andres <ma@xxxxxxx>]

On Monday 20 September 2010 13:19:14 Zhang, Qiang Z wrote:
> > Hmm, why handle "noproxy" different from "proxy"? I.e. why is there
> > an extra disable_proxy argument, but all other settings (like
> > "proxy" are detected later on in fillSettingsFromUrl()?
>
> [Zhang, Qiang] The "noproxy" param is just added to track the repo not to
> use proxy, so I think I need to remove this param before transfer to
> MediaCurl, as MediaCurl -> MediaHandler -> _url is a const type(const Url
>  _url), so I can't remove param from MediaCurl.
>
> So, I add an additional argument in the constructor of MediaCurl and add an
> additional variable in MediaCurl to note the proxy info for Url.

IMO it should be passed to MediaCurl via the Url:
 - no need to change the Media interfaces
 - no need for any extra handling outside MediaCurl

If the original Url needs to be modified (e.g. to remove params), MediaCurls 
ctor could arrange this, or MediaCurl creates a copy and cleans it before 
passing it to libcurl.

-- 

cu,
    Michael Andres

+------------------------------------------------------------------+
Key fingerprint = 2DFA 5D73 18B1 E7EF A862  27AC 3FB8 9E3A 27C6 B0E4
+------------------------------------------------------------------+
Michael Andres             ZYPP Development               ma@xxxxxxx
SUSE LINUX Products GmbH, GF:  Markus Rex,  HRB 16746 (AG Nuernberg)
Maxfeldstrasse 5, D-90409 Nuernberg, Germany, ++49 (0)911 - 740 53-0
+------------------------------------------------------------------+

--
To unsubscribe, e-mail: zypp-devel+unsubscribe@xxxxxxxxxxxx
For additional commands, e-mail: zypp-devel+help@xxxxxxxxxxxx