Mailinglist Archive: zypp-devel (24 mails)

< Previous Next >
Re: [zypp-devel] Don't link unneeded libraries. (bnc #490895) commit 91f064a4fbdeac9d6e4633c00b2979ed7dd08291
  • From: Michael Andres <ma@xxxxxxx>
  • Date: Thu, 2 Apr 2009 14:44:01 +0100
  • Message-id: <200904021544.01459.ma@xxxxxxx>
On Thursday 02 April 2009 15:33:06 Cristian Rodríguez wrote:
This change looks wrong IMHO

http://git.opensuse.org/?p=projects/zypp/libzypp.git;a=blobdiff;f=CMakeList
s.txt;h=d79a8b3959c0642146cac7a65364b9e1173acdb5;hp=114f2aadfd963dcc7d501677
35a6bc2362a6a1a2;hb=91f064a4fbdeac9d6e4633c00b2979ed7dd08291;hpb=d74d2aefc7c
ac89cbf351e236b8d54d5f3dec5df


Shouldnt that be in LINK_FLAGS instead of CFLAGS ?

Commit 91f064a4fbdeac9d6e4633c00b2979ed7dd08291 affected two files.
zypp/CMakeLists.txt contains the LINK_FLAGS.


--- a/zypp/CMakeLists.txt
+++ b/zypp/CMakeLists.txt
@@ -866,6 +866,7 @@ SET_LOGGROUP( "satsolver" ${zypp_sat_SRCS} )
ADD_LIBRARY(zypp SHARED ${zypp_lib_SRCS})
SET_TARGET_PROPERTIES( zypp PROPERTIES VERSION "${LIBZYPP_VERSION_INFO}" )
SET_TARGET_PROPERTIES( zypp PROPERTIES
SOVERSION "${LIBZYPP_SOVERSION_INFO}" )

+SET_TARGET_PROPERTIES( zypp PROPERTIES LINK_FLAGS "--as-needed" )

ADD_DEPENDENCIES(zypp schema_header)
# System libraries
SET(UTIL_LIBRARY util)

--

cu,
Michael Andres

+------------------------------------------------------------------+
Key fingerprint = 2DFA 5D73 18B1 E7EF A862 27AC 3FB8 9E3A 27C6 B0E4
+------------------------------------------------------------------+
Michael Andres YaST Development ma@xxxxxxxxxx
SUSE LINUX Products GmbH, GF: Markus Rex, HRB 16746 (AG Nuernberg)
Maxfeldstrasse 5, D-90409 Nuernberg, Germany, ++49 (0)911 - 740 53-0
+------------------------------------------------------------------+

--
To unsubscribe, e-mail: zypp-devel+unsubscribe@xxxxxxxxxxxx
For additional commands, e-mail: zypp-devel+help@xxxxxxxxxxxx

< Previous Next >
References