Mailinglist Archive: zypp-devel (102 mails)
| < Previous | Next > |
Re: [zypp-devel] [PATCH 3/3] Fix Python testcase for the Solver
- From: Jan Blunck <jblunck@xxxxxxx>
- Date: Tue, 17 Mar 2009 15:19:45 +0100
- Message-id: <20090317141945.GV23737@xxxxxxxxxxxxxxx>
On Tue, Mar 17, Klaus Kaempf wrote:
Actually there is not get() method anymore.
I don't think that the pool iterator belongs to the solvable testcase. Since
it started with a return statement it wasn't actually testing anything at all.
What would make sense would be:
def test_pool_iterate:
for s in self.pool:
assert s.pool() == self.pool
Cheers,
Jan
--
To unsubscribe, e-mail: zypp-devel+unsubscribe@xxxxxxxxxxxx
For additional commands, e-mail: zypp-devel+help@xxxxxxxxxxxx
* Jan Blunck <jblunck@xxxxxxx> [Mar 17. 2009 14:46]:
Ask the Solver for a specific provider instead of the Solvable id in the
pool.
Thanks for your patch. I will take your additional testcase (assertion
that only one product is in the pool) but keep the deleted (test 'get'
and test 'pool iterator') ones.
Actually there is not get() method anymore.
I don't think that the pool iterator belongs to the solvable testcase. Since
it started with a return statement it wasn't actually testing anything at all.
What would make sense would be:
def test_pool_iterate:
for s in self.pool:
assert s.pool() == self.pool
Cheers,
Jan
--
To unsubscribe, e-mail: zypp-devel+unsubscribe@xxxxxxxxxxxx
For additional commands, e-mail: zypp-devel+help@xxxxxxxxxxxx
| < Previous | Next > |