Mailinglist Archive: zypp-devel (102 mails)
| < Previous | Next > |
[zypp-devel] [PATCH 1/3] Let Solver.solve() return a bool in Python
- From: Jan Blunck <jblunck@xxxxxxx>
- Date: Tue, 17 Mar 2009 14:36:45 +0100
- Message-id: <1237297007-22539-1-git-send-email-jblunck@xxxxxxx>
Let the Python binding return a bool from Solver.solve() as described in
the documentation.
Signed-off-by: Jan Blunck <jblunck@xxxxxxx>
---
bindings/python/tests/solvable.py | 5 +++--
bindings/solver.i | 5 +++++
2 files changed, 8 insertions(+), 2 deletions(-)
diff --git a/bindings/python/tests/solvable.py
b/bindings/python/tests/solvable.py
index d25a389..7c53659 100644
--- a/bindings/python/tests/solvable.py
+++ b/bindings/python/tests/solvable.py
@@ -76,9 +76,10 @@ class TestSequenceFunctions(unittest.TestCase):
transaction = self.pool.create_transaction()
transaction.install( solv1 )
- solver = self.pool.create_solver( self.pool.create_repo( "system" ) )
+ solver = self.pool.create_solver()
# self.pool.debug = 255
- solver.solve( transaction )
+ res = solver.solve( transaction )
+ assert res.__class__.__name__ == 'bool', res.__class__.__name__
# solver.each_to_install { |s|
# puts "Install #{s}"
# }
diff --git a/bindings/solver.i b/bindings/solver.i
index 768793d..ea9c3c3 100644
--- a/bindings/solver.i
+++ b/bindings/solver.i
@@ -785,6 +785,11 @@ typedef struct solver {} Solver;
%typemap(out) int solve
"$result = $1 ? Qtrue : Qfalse;";
#endif
+#if defined(SWIGPYTHON)
+%typemap(out) int solve {
+ $result = PyBool_FromLong((long) ($1 ? 1 : 0));
+}
+#endif
/*
* Solve the given Transaction
*
--
1.6.1.3
--
To unsubscribe, e-mail: zypp-devel+unsubscribe@xxxxxxxxxxxx
For additional commands, e-mail: zypp-devel+help@xxxxxxxxxxxx
the documentation.
Signed-off-by: Jan Blunck <jblunck@xxxxxxx>
---
bindings/python/tests/solvable.py | 5 +++--
bindings/solver.i | 5 +++++
2 files changed, 8 insertions(+), 2 deletions(-)
diff --git a/bindings/python/tests/solvable.py
b/bindings/python/tests/solvable.py
index d25a389..7c53659 100644
--- a/bindings/python/tests/solvable.py
+++ b/bindings/python/tests/solvable.py
@@ -76,9 +76,10 @@ class TestSequenceFunctions(unittest.TestCase):
transaction = self.pool.create_transaction()
transaction.install( solv1 )
- solver = self.pool.create_solver( self.pool.create_repo( "system" ) )
+ solver = self.pool.create_solver()
# self.pool.debug = 255
- solver.solve( transaction )
+ res = solver.solve( transaction )
+ assert res.__class__.__name__ == 'bool', res.__class__.__name__
# solver.each_to_install { |s|
# puts "Install #{s}"
# }
diff --git a/bindings/solver.i b/bindings/solver.i
index 768793d..ea9c3c3 100644
--- a/bindings/solver.i
+++ b/bindings/solver.i
@@ -785,6 +785,11 @@ typedef struct solver {} Solver;
%typemap(out) int solve
"$result = $1 ? Qtrue : Qfalse;";
#endif
+#if defined(SWIGPYTHON)
+%typemap(out) int solve {
+ $result = PyBool_FromLong((long) ($1 ? 1 : 0));
+}
+#endif
/*
* Solve the given Transaction
*
--
1.6.1.3
--
To unsubscribe, e-mail: zypp-devel+unsubscribe@xxxxxxxxxxxx
For additional commands, e-mail: zypp-devel+help@xxxxxxxxxxxx
| < Previous | Next > |