Mailinglist Archive: zypp-devel (53 mails)

< Previous Next >
Re: [zypp-devel] Re: [zypp-commit] r11408 - /trunk/libzypp/zypp/repo/PackageDelta.cc
  • From: Klaus Kaempf <kkaempf@xxxxxxx>
  • Date: Mon, 20 Oct 2008 16:09:57 +0200
  • Message-id: <20081020140957.GA4621@xxxxxxxxxxxxx>
* Klaus Kaempf <kkaempf@xxxxxxx> [Oct 20. 2008 16:07]:
* Michael Andres <ma@xxxxxxx> [Oct 20. 2008 16:00]:
On Monday 20 October 2008 15:30:48 kkaempf@xxxxxxxxxxxxxxxx wrote:

Log:
fix Dataiterator_init call

Modified:
trunk/libzypp/zypp/repo/PackageDelta.cc

Modified: trunk/libzypp/zypp/repo/PackageDelta.cc
URL:
http://svn.opensuse.org/viewcvs/zypp/trunk/libzypp/zypp/repo/PackageDelta.c
c?rev=11408&r1=11407&r2=11408&view=diff
===========================================================================
=== --- trunk/libzypp/zypp/repo/PackageDelta.cc (original)
+++ trunk/libzypp/zypp/repo/PackageDelta.cc Mon Oct 20 15:30:48 2008
@@ -36,7 +36,7 @@
{
MIL << "creating deltarpm from repo " << repo.alias() << ", id " <<
extraid << endl;

::Dataiterator di;

- ::dataiterator_init(&di, repo.get(), extraid, 0, 0, 0);
+ ::dataiterator_init(&di, NULL, repo.get(), extraid, 0, 0, 0);

Don't fix it that way. dataiterator_init segfaults with a NULL pool.

Sorry. Then *please* lets fix dataiterator_init to get fetch
repo->pool if pool is NULL.

Fixed in satsolver/src/repodata.c
Please have a look.

Klaus
--
To unsubscribe, e-mail: zypp-devel+unsubscribe@xxxxxxxxxxxx
For additional commands, e-mail: zypp-devel+help@xxxxxxxxxxxx

< Previous Next >
Follow Ups