Mailinglist Archive: zypp-devel (53 mails)
| < Previous | Next > |
Re: [zypp-devel] Re: MediaAria2c merged
- From: Duncan Mac-Vicar Prett <dmacvicar@xxxxxxx>
- Date: Mon, 06 Oct 2008 17:42:34 +0200
- Message-id: <48EA31EA.3060604@xxxxxxx>
Michael Matz wrote:
Duncan
--
To unsubscribe, e-mail: zypp-devel+unsubscribe@xxxxxxxxxxxx
For additional commands, e-mail: zypp-devel+help@xxxxxxxxxxxx
But it would be very nice if someone cleaned up the code ofYes, that is planned.
MediaAria2c.cc. From a cursory read some weeks ago it is mostly a c&p of
MediaCurl.cc (and in fact still uses curl for most of it's things, except
of course for the crucial one of downloading files), and exchanged only a
couple of functions. I'd much rather see MediaAria2c be a subclass of
MediaCurl reusing much of its code.
Code duplication is bad.Does that include string join and split functions? ;-)
Duncan
--
To unsubscribe, e-mail: zypp-devel+unsubscribe@xxxxxxxxxxxx
For additional commands, e-mail: zypp-devel+help@xxxxxxxxxxxx
| < Previous | Next > |