Mailinglist Archive: zypp-devel (53 mails)

[Michael Matz <matz@xxxxxxx>]

Hi,

On Tue, 30 Sep 2008, Stanislav Visnovsky wrote:

> Dňa Tuesday 30 September 2008 01:46:55 Peter Poeml ste napísal:
> > On Tue, Sep 30, 2008 at 12:13:54 +0200, Duncan Mac-Vicar P. wrote:
> > > MediaAria2c is now official part of libzypp.
> > >
> > > MediaAria2c és ara part oficial de libzypp!
> >
> > That's great. Thank you very much for this effort Duncan.
>
> Yes, this is really cool! Thanks a lot to all involved.

But it would be very nice if someone cleaned up the code of 
MediaAria2c.cc.  From a cursory read some weeks ago it is mostly a c&p of 
MediaCurl.cc (and in fact still uses curl for most of it's things, except 
of course for the crucial one of downloading files), and exchanged only a 
couple of functions.  I'd much rather see MediaAria2c be a subclass of 
MediaCurl reusing much of its code.

Code duplication is bad.


Ciao,
Michael.