Mailinglist Archive: zypp-devel (83 mails)
| < Previous | Next > |
Re: [zypp-devel] [OT] multiple source file renames
- From: Michael Matz <matz@xxxxxxx>
- Date: Mon, 23 Jun 2008 15:22:19 +0200 (CEST)
- Message-id: <Pine.LNX.4.64.0806231502090.30076@xxxxxxxxxxxxx>
Hi,
On Sat, 21 Jun 2008, Jano Kupec wrote:
Bah!
1) Never rename source files: breaks patches without good reason.
2) Don't use capitals in file names: useless use of keypresses.
3) Use "svn mv"
4) Goto 1
If anything, merge the split step with the rename, i.e. move functions
from the old big files into new small files named to your liking.
The hoops you are trying to jump through to make patches work should
make it pretty obvious that this renaming is not a clever idea.
Just IMO :) zypper is mostly your child, so in the end what really
matters is your preference, in that case please at least do (3) ;-)
Ciao,
Michael.
--
To unsubscribe, e-mail: zypp-devel+unsubscribe@xxxxxxxxxxxx
For additional commands, e-mail: zypp-devel+help@xxxxxxxxxxxx
On Sat, 21 Jun 2008, Jano Kupec wrote:
i'm wondering what is your opinion on this. Before starting with coding
for 11.1 i intend to reorganize zypper's sources a bit to avoid too much
typing (each file has 'zypper-' prefix), to reduce compilation time, and
to split zypper-misc.* and zypper-utils.* which currently mix too much
stuff together. All to make the code easier and more pleasant to work
with.
Some of this is obvious, but the rename part first. I intend to do the
following:
Bah!
1) Never rename source files: breaks patches without good reason.
2) Don't use capitals in file names: useless use of keypresses.
3) Use "svn mv"
4) Goto 1
If anything, merge the split step with the rename, i.e. move functions
from the old big files into new small files named to your liking.
The hoops you are trying to jump through to make patches work should
make it pretty obvious that this renaming is not a clever idea.
Just IMO :) zypper is mostly your child, so in the end what really
matters is your preference, in that case please at least do (3) ;-)
Ciao,
Michael.
--
To unsubscribe, e-mail: zypp-devel+unsubscribe@xxxxxxxxxxxx
For additional commands, e-mail: zypp-devel+help@xxxxxxxxxxxx
| < Previous | Next > |