Mailinglist Archive: zypp-devel (75 mails)

[josef reidiner <jreidinger@xxxxxxx>]

Stephan Kulow napsal(a):
> Am Freitag, 16. Mai 2008 schrieben Sie:
> > Stephan Kulow napsal(a):
> > > Hi,
> > >
> > > Looks like the implementation of locks has all the old
> > > problems ;(
> > >
> > > I cancelled the callgrind call, but till then it called
> > > 415 826 times PoolQueryIterator::matchSolvable, which in
> > > turn costed 28 382 428 146 instructions.
> > >
> > > Greetings, Stephan
> > Locks depends on PoolQuery which uses DataIterator...if we expect lot of
> > locks from ui, which is exact string match, then we can optimalize
> > PoolQuery (or directly locks by extracting information about lock from
> > query) for this (e.g. using index on names).
>
> I think one problem is that "zypper addlock kernel-debug" adds 
> match_type: glob (no idea why)
>
> And then you do a glob search even if there are no * or ? - which
> could be optimized too.
>
> Greetings, Stephan

I agree, this is ineffective and check for * or ? is quite fast during 
adding. I add it if jano isn't faster :)

--
To unsubscribe, e-mail: zypp-devel+unsubscribe@xxxxxxxxxxxx
For additional commands, e-mail: zypp-devel+help@xxxxxxxxxxxx