Michael Schroeder wrote:
On Thu, Apr 24, 2008 at 04:23:25PM +0200, Josef Reidinger wrote:
Hi, I create wiki page[1] about locks format. Please fill info about solvattr which i don't know. One interesting thing is, that locks accept everything from knowid from sat-solver, because I pass string with attribute to poolquery and poolquery fill this string to dataiterator which know it. so also much undocumented attributes work (e.g. provides or evr).
Thanks for putting that in the wiki.
Some comments:
1) I don't think you should support "global_string" at all. I don't see any real-life use case.
2) IMHO the default should not be "substring", but "exact". The default should also not be case sensitive. (please use least surprising defaults)
3) I think we no longer support atom/message/script kinds.
4) I'm not sore we really need that "solvable_" prefix. It just makes things hard to read.
Cheers, Michael.
Thanks for responses. 1) idea behing locks is that it lock everything which can be result of search. So it use serialized query. Jano have this string in PoolQuery so I also support it. I can undocument it and have it only as undocumented feature with no guarantee or support. 2) jano think that regex can be default. Problem is that query have default substring so it must have some hack to change it (and have some real problems with it - like if I read query and it have search by substring - is this substring users substring or it is default value and change it to regex?). maybe you overlook case-sensitive, but default is !in!sensitive 3) I write documentation from code, If we don't support it. I remove it from documentation. 4) This is serious problem. When I propose api I have two ways a) have flexible implementation which uses SolvAttr for reading, so when someone extend SolvAttr Locks automatic support it. b) have own variables which I translate to SolvAttr which uses PoolQuery. When SolvAttr change, I must also change locks variables. also translate from own Attribute to/from solvAttribute is non-trivial (but possible). I decide use way a). But this result in using solvable names (only replace/:/_). If every Solvable attributes uses solvable prefix I easy can add it and remove it, but they also have update prefix and some hasn't prefix, so this is not possible. I see two ways - 1) change names in knowid.h (in sat-solver) 2) change implementation to b) with all negatives any other idea how can I solve it? Pepa -- To unsubscribe, e-mail: zypp-devel+unsubscribe@opensuse.org For additional commands, e-mail: zypp-devel+help@opensuse.org