Mailinglist Archive: zypp-devel (227 mails)

[Michael Matz <matz@xxxxxxx>]

Hi Klaus,

On Mon, 7 Apr 2008, kkaempf@xxxxxxxxxxxxxxxx wrote:

> Author: kkaempf
> Date: Mon Apr  7 16:11:23 2008
> New Revision: 9426
>
> URL: http://svn.opensuse.org/viewcvs/zypp?rev=9426&view=rev
> Log:
> parse <package-manager/> to 'update:restart' attribute
>
> Modified:
>     trunk/sat-solver/tools/repo_patchxml.c
>
> @@ -81,6 +82,7 @@
>    { STATE_PATCH,       "description",     STATE_DESCRIPTION, 1 },
>    { STATE_PATCH,       "category",        STATE_CATEGORY, 1 },
>    { STATE_PATCH,       "reboot-needed",   STATE_REBOOT, 0 },
> +  { STATE_PATCH,       "package-manager", STATE_RESTART, 0 },

You don't parse the content of this tag here (which makes sense as you 
mentioned "<package-manager/>", i.e. a content-less tag) ...

>    { STATE_PATCH,       "rpm:requires",    STATE_REQUIRES, 0 },
>    { STATE_PATCH,       "rpm:provides",    STATE_PROVIDES, 0 },
>    { STATE_PATCH,       "rpm:requires",    STATE_REQUIRES, 0 },
> @@ -579,6 +581,9 @@
>      case STATE_REBOOT:
>        repodata_set_str(pd->data, pd->datanum, UPDATE_REBOOT, pd->content);
>        break;  
> +    case STATE_RESTART:
> +      repodata_set_str(pd->data, pd->datanum, UPDATE_RESTART, pd->content);
> +      break;  

... but this means that pd->content will be empty, of course.  Which means 
it doesn't make sense to store this attribute as a string.  It seems the 
mere existence of it has significance.  If that is the case then please 
use repodata_set_void().

It's the same for the other attributes you recently added.


Ciao,
Michael.
-- 
To unsubscribe, e-mail: zypp-devel+unsubscribe@xxxxxxxxxxxx
For additional commands, e-mail: zypp-devel+help@xxxxxxxxxxxx