Mailinglist Archive: zypp-devel (230 mails)

< Previous Next >
Re: [zypp-devel] Re: Preliminary zypper port
  • From: "Duncan Mac-Vicar P." <dmacvicar@xxxxxxx>
  • Date: Mon, 04 Feb 2008 22:09:00 +0100
  • Message-id: <47A77EEC.6030805@xxxxxxx>
Michael Andres wrote:
On Sun, Feb 03, Duncan Mac-Vicar P. wrote:


- the first try, zypper hangs and eats all ram just after loading proxy
settings. I unittested the parser and it was OK. So the codepath that


Mea culpa. fixed in revision 8459.

(str::split running wild)


heh:
freenode_#yast.log:[Sat Feb 2 2008] [20:56:27] <duncanmv> coolo: I
found the problem, michael andres broke all string utility functions
some days ago

So this time you committed a unit test for String.h ? :-)

+#include "zypp/ManagedFile.h"

switch ( repokind.toEnum() )
{
case RepoType::RPMMD_e :
case RepoType::YAST2_e :
{
MIL << "Executing solv converter" << endl;
+ // Take care we unlink the solvfile on exception
+ ManagedFile guard( solvfile, filesystem::erase );

- string cmd( str::form( "repo2solv.sh \"%s\" > %s",
+ string cmd( str::form( "repo2solv.sh \"%s\" > '%s'",
rawpath.c_str(), solvfile.c_str() ) );
ExternalProgram prog( cmd, ExternalProgram::Stderr_To_Stdout );
for ( string output( prog.receiveLine() );
output.length(); output = prog.receiveLine() ) {
MIL << " " << output;
}
int ret = prog.close();
if ( ret != 0 )
ZYPP_THROW(RepoUnknownTypeException());

+ // We keep it.
+ guard.resetDispose();
}
break;
default:
ZYPP_THROW(Exception("Unhandled repostory type"));
break;
}


thanks! I forgot about this class

Duncan

--
To unsubscribe, e-mail: zypp-devel+unsubscribe@xxxxxxxxxxxx
For additional commands, e-mail: zypp-devel+help@xxxxxxxxxxxx

< Previous Next >
Follow Ups