Mailinglist Archive: zypp-devel (57 mails)
| < Previous | Next > |
[zypp-devel] [patch] language improvements in comments
- From: Leonardo Chiquitto <leonardo.lists@xxxxxxxxx>
- Date: Fri, 4 Jan 2008 11:20:50 -0200
- Message-id: <20080104132048.GA11700@xxxxxxxxxxxxxxxx>
Hello,
While reading Zypp and Libzypp sources, I found a couple of typos in
some comments. Here's a patch.
Thanks,
Leonardo
Index: zypp/libzypp/zypp/Arch.h
===================================================================
--- zypp.orig/libzypp/zypp/Arch.h
+++ zypp/libzypp/zypp/Arch.h
@@ -106,7 +106,7 @@ namespace zypp
/** \name Builtin architecture constants.
*
* Defined outside Arch as e.g. \c Arch_i386, because some names,
- * like \c i388, are used as \c #define, thus unusable as identifier
+ * like \c i386, are used as \c #define, thus unusable as identifier
* like \c Arch::i386.
*/
//@{
@@ -203,6 +203,6 @@ namespace std
inline bool less<zypp::Arch>::operator()( const zypp::Arch & lhs, const
zypp::Arch & rhs ) const
{ return lhs.compare( rhs ) < 0; }
/////////////////////////////////////////////////////////////////
-} // namespace zypp
+} // namespace std
///////////////////////////////////////////////////////////////////
#endif // ZYPP_ARCH_H
Index: zypp/libzypp/zypp/Arch.cc
===================================================================
--- zypp.orig/libzypp/zypp/Arch.cc
+++ zypp/libzypp/zypp/Arch.cc
@@ -27,10 +27,10 @@ namespace zypp
//
// CLASS NAME : Arch::CompatEntry
//
- /** Holds an architecture ID and it's compatible relation.
- * An architecture is compatibleWith, if it's _idBit is set in
+ /** Holds an architecture ID and its compatible relation.
+ * An architecture is compatibleWith, if its _idBit is set in
* _compatBits. noarch has ID 0, non builtin archs id 1 and
- * have to be treated specialy.
+ * have to be treated specially.
*/
struct Arch::CompatEntry
{
@@ -62,7 +62,7 @@ namespace zypp
switch ( _idBit.value() )
{
case 0:
- // this is noarch and always comatible
+ // this is noarch and always compatible
return true;
break;
case 1:
@@ -186,7 +186,7 @@ namespace zypp
{
// _noarch must have _idBit 0.
// Other builtins have 1-bit set
- // and are initialized done on the fly.
+ // and are initialized on the fly.
_compatSet.insert( Arch::CompatEntry( _noarch, 0 ) );
///////////////////////////////////////////////////////////////////
// Define the CompatibleWith relation:
@@ -244,7 +244,7 @@ namespace zypp
/** Return the next avialable _idBit.
* Ctor injects _noarch into the _compatSet, 1 is for
* nonbuiltin archs, so we can use <tt>size</tt> for
- * buitin archs.
+ * builtin archs.
*/
CompatBits::IntT nextIdBit() const
{
Index: zypp/libzypp/zypp/Resolvable.h
===================================================================
--- zypp.orig/libzypp/zypp/Resolvable.h
+++ zypp/libzypp/zypp/Resolvable.h
@@ -91,7 +91,7 @@ namespace zypp
///////////////////////////////////////////////////////////////////
/** Test whether a Resolvable::Ptr is of a certain Kind.
- * \return \c Ture iff \a p is not \c NULL and points to a Resolvable
+ * \return \c True iff \a p is not \c NULL and points to a Resolvable
* of the specified Kind.
* \relates Resolvable
* \code
Index: zypp/zypper/src/zypper-main.h
===================================================================
--- zypp.orig/zypper/src/zypper-main.h
+++ zypp/zypper/src/zypper-main.h
@@ -7,7 +7,7 @@
#define ZYPPER_EXIT_OK 0
// errors
-#define ZYPPER_EXIT_ERR_BUG 1 // undetermined error
+#define ZYPPER_EXIT_ERR_BUG 1 // undefined error
#define ZYPPER_EXIT_ERR_SYNTAX 2 // syntax error, e.g. zypper
instal, zypper in --unknown option
#define ZYPPER_EXIT_ERR_INVALID_ARGS 3 // invalid arguments given, e.g.
zypper source-add httttps://asdf.net
#define ZYPPER_EXIT_ERR_ZYPP 4 // error indicated from within
libzypp, e.g. God = zypp::getZYpp() threw an exception
@@ -34,10 +34,10 @@
#define COND_STREAM(STREAM,LEVEL) ((Zypper::instance()->globalOpts().verbosity
/** \name Output Macros
- * Alway use these macros to produce output so that the verbosity options
+ * Always use these macros to produce output so that the verbosity options
* like -v or --quiet are respected. Use standard cout and cerr only in
* cases where it is desirable to ignore them (e.g. help texts (when -h is
- * used) or brief error messages must always be displayed, even if --quiet
+ * used) or brief error messages that must always be displayed, even if --quiet
* has been specified).
*/
//!@{
--
To unsubscribe, e-mail: zypp-devel+unsubscribe@xxxxxxxxxxxx
For additional commands, e-mail: zypp-devel+help@xxxxxxxxxxxx
While reading Zypp and Libzypp sources, I found a couple of typos in
some comments. Here's a patch.
Thanks,
Leonardo
Index: zypp/libzypp/zypp/Arch.h
===================================================================
--- zypp.orig/libzypp/zypp/Arch.h
+++ zypp/libzypp/zypp/Arch.h
@@ -106,7 +106,7 @@ namespace zypp
/** \name Builtin architecture constants.
*
* Defined outside Arch as e.g. \c Arch_i386, because some names,
- * like \c i388, are used as \c #define, thus unusable as identifier
+ * like \c i386, are used as \c #define, thus unusable as identifier
* like \c Arch::i386.
*/
//@{
@@ -203,6 +203,6 @@ namespace std
inline bool less<zypp::Arch>::operator()( const zypp::Arch & lhs, const
zypp::Arch & rhs ) const
{ return lhs.compare( rhs ) < 0; }
/////////////////////////////////////////////////////////////////
-} // namespace zypp
+} // namespace std
///////////////////////////////////////////////////////////////////
#endif // ZYPP_ARCH_H
Index: zypp/libzypp/zypp/Arch.cc
===================================================================
--- zypp.orig/libzypp/zypp/Arch.cc
+++ zypp/libzypp/zypp/Arch.cc
@@ -27,10 +27,10 @@ namespace zypp
//
// CLASS NAME : Arch::CompatEntry
//
- /** Holds an architecture ID and it's compatible relation.
- * An architecture is compatibleWith, if it's _idBit is set in
+ /** Holds an architecture ID and its compatible relation.
+ * An architecture is compatibleWith, if its _idBit is set in
* _compatBits. noarch has ID 0, non builtin archs id 1 and
- * have to be treated specialy.
+ * have to be treated specially.
*/
struct Arch::CompatEntry
{
@@ -62,7 +62,7 @@ namespace zypp
switch ( _idBit.value() )
{
case 0:
- // this is noarch and always comatible
+ // this is noarch and always compatible
return true;
break;
case 1:
@@ -186,7 +186,7 @@ namespace zypp
{
// _noarch must have _idBit 0.
// Other builtins have 1-bit set
- // and are initialized done on the fly.
+ // and are initialized on the fly.
_compatSet.insert( Arch::CompatEntry( _noarch, 0 ) );
///////////////////////////////////////////////////////////////////
// Define the CompatibleWith relation:
@@ -244,7 +244,7 @@ namespace zypp
/** Return the next avialable _idBit.
* Ctor injects _noarch into the _compatSet, 1 is for
* nonbuiltin archs, so we can use <tt>size</tt> for
- * buitin archs.
+ * builtin archs.
*/
CompatBits::IntT nextIdBit() const
{
Index: zypp/libzypp/zypp/Resolvable.h
===================================================================
--- zypp.orig/libzypp/zypp/Resolvable.h
+++ zypp/libzypp/zypp/Resolvable.h
@@ -91,7 +91,7 @@ namespace zypp
///////////////////////////////////////////////////////////////////
/** Test whether a Resolvable::Ptr is of a certain Kind.
- * \return \c Ture iff \a p is not \c NULL and points to a Resolvable
+ * \return \c True iff \a p is not \c NULL and points to a Resolvable
* of the specified Kind.
* \relates Resolvable
* \code
Index: zypp/zypper/src/zypper-main.h
===================================================================
--- zypp.orig/zypper/src/zypper-main.h
+++ zypp/zypper/src/zypper-main.h
@@ -7,7 +7,7 @@
#define ZYPPER_EXIT_OK 0
// errors
-#define ZYPPER_EXIT_ERR_BUG 1 // undetermined error
+#define ZYPPER_EXIT_ERR_BUG 1 // undefined error
#define ZYPPER_EXIT_ERR_SYNTAX 2 // syntax error, e.g. zypper
instal, zypper in --unknown option
#define ZYPPER_EXIT_ERR_INVALID_ARGS 3 // invalid arguments given, e.g.
zypper source-add httttps://asdf.net
#define ZYPPER_EXIT_ERR_ZYPP 4 // error indicated from within
libzypp, e.g. God = zypp::getZYpp() threw an exception
@@ -34,10 +34,10 @@
#define COND_STREAM(STREAM,LEVEL) ((Zypper::instance()->globalOpts().verbosity
= LEVEL) ? STREAM : no_stream)
/** \name Output Macros
- * Alway use these macros to produce output so that the verbosity options
+ * Always use these macros to produce output so that the verbosity options
* like -v or --quiet are respected. Use standard cout and cerr only in
* cases where it is desirable to ignore them (e.g. help texts (when -h is
- * used) or brief error messages must always be displayed, even if --quiet
+ * used) or brief error messages that must always be displayed, even if --quiet
* has been specified).
*/
//!@{
--
To unsubscribe, e-mail: zypp-devel+unsubscribe@xxxxxxxxxxxx
For additional commands, e-mail: zypp-devel+help@xxxxxxxxxxxx
| < Previous | Next > |