Mailinglist Archive: zypp-devel (114 mails)

[Jan Kupec <jkupec@xxxxxxx>]

Michael Andres wrote:
> On Mon, Jul 30, Jan Kupec wrote:
> 
>> 2) with the refactored libzypp we have no means to change the URL as we
>>    did before. The URL edit box has no effect now in YaST dialogs due to
>>    this fact. (zypper didn't have this implemented so far.)
>>
>>    This is again because we don't have repositories globally associated
>>    with media access, and there is nothing like simple
>>    redirect(media, newurl) call now.
> 
> As far as I see, the requestMedia callback still has the old signature:
> 
>      virtual Action requestMedia( 
>                 Repository              /*source*/
>                 , unsigned              /*mediumNr*/
>                 , Error                 /*error*/
>                 , const std::string &       /*description*/ );
> 
> 
> And as we no longer have the Repository available, always
> Repository::noRepository is passed to the callback.
> 
> 
> What about removing the now unused Repository argument, and
> introducing an 'Url & newUrl'?
> 
> If the returned Action == media::MediaChangeReport::CHANGE_URL,
> we expect url to contain the new URL to use.

Yes, then the MediaSetAccess can reattach the new URL.

But this may be not a way to go, since we create MediaSetAccess on
several places (with URL read from RepoInfo mostly, if not everywhere),
we would get the change request pop-up several times, one time for each
MediaSetAccess created and used (repo manipulation and commit at least).

j.
-- 
To unsubscribe, e-mail: zypp-devel+unsubscribe@xxxxxxxxxxxx
For additional commands, e-mail: zypp-devel+help@xxxxxxxxxxxx