Mailinglist Archive: zypp-devel (116 mails)

[Duncan Mac-Vicar Prett <dmacvicar@xxxxxxx>]

On Monday 04 June 2007 17:39:57 Jan Kupec wrote:
> The only thing i would change in the code is to add
> RepoManager::isCached(repo) and use it to check if the repo is cached
> instead of catching the exception.

Yes. I agree.

> I'd like an additional 'force' bool arg here defaulting to false which
> would cause a refresh even if everything indicates that it is not
> needed. (for use with e.g. zypper refresh --force or --full).

good point. I would use either a RefreshOpts class or a different method. We 
have bad experience with bool parameters as flag to change behavior.

> Nope. You are not calling repository.createResolvables() anywhere :O)
> Commited, check it out now.

Thanks. This has to be done in the RepostoryImpl resolvables() call.

> > All paths are passed in the RepoManagerOptions parameter, which default
> > to the ZYpp global paths.

Yeah, designed to be tested. When you test, you always want to use TmpDirs 
everywhere.

-- 
Duncan Mac-Vicar Prett  
Novell :: SUSE R&D, Maxfeldstr. 5, 90409 Nürnberg
GF: Markus Rex, HRB 16746 (AG Nürnberg)
--
To unsubscribe, e-mail: zypp-devel+unsubscribe@xxxxxxxxxxxx
For additional commands, e-mail: zypp-devel+help@xxxxxxxxxxxx