Mailinglist Archive: zypp-commit (339 mails)

[mlandres@xxxxxxxxxxxxxxxx]

Author: mlandres
Date: Fri Oct 17 17:32:16 2008
New Revision: 11396

URL: http://svn.opensuse.org/viewcvs/zypp?rev=11396&view=rev
Log:
Cache target distribution version instead of permanently calling rpmdb2solv

Modified:
    trunk/libzypp/zypp/target/TargetImpl.cc
    trunk/libzypp/zypp/target/TargetImpl.h

Modified: trunk/libzypp/zypp/target/TargetImpl.cc
URL: 
http://svn.opensuse.org/viewcvs/zypp/trunk/libzypp/zypp/target/TargetImpl.cc?rev=11396&r1=11395&r2=11396&view=diff
==============================================================================
--- trunk/libzypp/zypp/target/TargetImpl.cc (original)
+++ trunk/libzypp/zypp/target/TargetImpl.cc Fri Oct 17 17:32:16 2008
@@ -912,7 +912,15 @@
     { return rpmdb2solvAttr( "register.release", _root ); }
 
     std::string TargetImpl::distributionVersion() const
-    { return rpmdb2solvAttr( "releasever", _root ); }
+    {
+      if ( _distributionVersion.empty() )
+      {
+        _distributionVersion = rpmdb2solvAttr( "releasever", _root );
+        if ( !_distributionVersion.empty() )
+          MIL << "Remember distributionVersion = '" << _distributionVersion << 
"'" << endl;
+      }
+      return _distributionVersion;
+    }
 
     ///////////////////////////////////////////////////////////////////
 

Modified: trunk/libzypp/zypp/target/TargetImpl.h
URL: 
http://svn.opensuse.org/viewcvs/zypp/trunk/libzypp/zypp/target/TargetImpl.h?rev=11396&r1=11395&r2=11396&view=diff
==============================================================================
--- trunk/libzypp/zypp/target/TargetImpl.h (original)
+++ trunk/libzypp/zypp/target/TargetImpl.h Fri Oct 17 17:32:16 2008
@@ -146,7 +146,7 @@
 
       /** \copydoc Target::targetDistributionRelease()*/
       std::string targetDistributionRelease() const;
-      
+
       /** \copydoc Target::distributionVersion()*/
       std::string distributionVersion() const;
 
@@ -161,6 +161,8 @@
       SoftLocksFile _softLocksFile;
       /** Hard-Locks database */
       HardLocksFile _hardLocksFile;
+      /** Cache distributionVersion */
+      mutable std::string _distributionVersion;
     private:
       /** Null implementation */
       static TargetImpl_Ptr _nullimpl;

--
To unsubscribe, e-mail: zypp-commit+unsubscribe@xxxxxxxxxxxx
For additional commands, e-mail: zypp-commit+help@xxxxxxxxxxxx