On 12.8.2014 15:22, Ladislav Slezak wrote:
Dne 23.5.2014 10:04, Josef Reidinger napsal(a):
I agree. I just see one of rspec test using obsolete monkey patching with `instance.stub(...)`, so I will like to raise it to have easy switch to new rspec.
I've been just checking a PR made by Schubi: https://github.com/yast/yast-services-manager/pull/101 This also changes: - expect(ServicesManager.import(data)).to be_true + expect(ServicesManager.import(data)).to eq(true) According to documentation at https://github.com/rspec/rspec-expectations - we should be using expect(ServicesManager.import(data)).to be true but according to Ancor, we have to use expect(ServicesManager.import(data)).to eq(true) because this works with both, the old and the new version of RSpec. I wanted to make this clear so everyone has the same expectations when it comes to reviewing others' code. Thanks && Bye Lukas -- Lukas Ocilka, Systems Management (Yast) Team Leader Cloud & Systems Management Department, SUSE Linux -- To unsubscribe, e-mail: yast-devel+unsubscribe@opensuse.org To contact the owner, e-mail: yast-devel+owner@opensuse.org