Hello, On Dec 1 11:22 Ladislav Slezak wrote (excerpt):
https://github.com/yast/yast-yast2/commit/b3ff10aebd39aa0a446e6d7004fbe5821e...
On my 1920 pixel wide display, the diff viewport is 820 pixels no matter how I resize the browser window. ... I have tested it [1] and GitHub is able to display about 110-115 characters per line (depending on the browser, in chrome I could see 111 characters, in Firefox 115, but might depend on available fonts, display resolution etc...) So from the GitHub POV the
Dne 1.12.2014 v 10:01 Martin Vidner napsal(a): practical limit seems to be 110 characters. [1] https://github.com/lslezak/yast-ntp-client/pull/3/files
My Firefox shows at https://github.com/lslezak/yast-ntp-client/pull/3/files only -------------------------------------------------------------------- +01234567890123456789012345678901234567890123456789012345678901234 -------------------------------------------------------------------- i.e. only 66 characters. There is no such thing as a "practical value" for stubborn webdesign with a useless fixed main text viewport width specified in pixels. When text width is a fixed pixel value it results that it depends on the particular user's browser font how many characters fit into a fixed pixel value. I wished you could keep the reasonable freedom of the ideas behind https://github.com/SUSE/style-guides/blob/master/Ruby.md instead of following the bad ideas behind a fixed value (web)design. Kind Regards Johannes Meixner -- SUSE LINUX GmbH -- Maxfeldstrasse 5 -- 90409 Nuernberg -- Germany HRB 21284 (AG Nuernberg) GF: Jeff Hawn, Jennifer Guild, Felix Imendoerffer -- To unsubscribe, e-mail: yast-devel+unsubscribe@opensuse.org To contact the owner, e-mail: yast-devel+owner@opensuse.org