Dne Pá 7. října 2011 16:01:25 Ladislav Slezak napsal(a):
Dne 6.10.2011 08:51, jsuchome@svn2.opensuse.org napsal(a):
+ // help text + string help_text = _("<p>FIXME fill this</p>");
Do not forget to fix it ;-)
Yes, sure, others need to fill this (and they know).
+ SCR::Execute (.process.kill, pid);
It seems that the same (or very similar) code is also in firstboot_slepos_synchronization.ycp file, maybe it could be factored out and shared...
Maybe...
+ while (true) + { + ret = UI::UserInput (); + if (ret == `abort && !Popup::ConfirmAbort (`incomplete)) + { + continue; + } + else + { + break; + } + }
I think this could be rewritten to something like this:
do { ret = UI::UserInput(); } while(ret == `abort && !Popup::ConfirmAbort (`incomplete));
Yes, you are right, looks like there was some more there before and than got simplified. I may adapt this in next iteration (which will come soon). j -- Jiri Suchomel SUSE LINUX, s.r.o. e-mail: jsuchome@suse.cz Lihovarská 1060/12 tel: +420 284 028 960 190 00 Praha 9, Czech Republic http://www.suse.cz -- To unsubscribe, e-mail: yast-devel+unsubscribe@opensuse.org To contact the owner, e-mail: yast-devel+owner@opensuse.org