Branch: refs/heads/any-timed-message-fix
Home: https://github.com/yast/yast-yast2
Commit: 9a7d72abe6fb450d7684a014dbe897775a3d03ff
https://github.com/yast/yast-yast2/commit/9a7d72abe6fb450d7684a014dbe897775a...
Author: Martin Vidner
Date: 2016-07-29 (Fri, 29 Jul 2016)
Changed paths:
M library/general/src/modules/Popup.rb
M library/general/test/popup_test.rb
Log Message:
-----------
Use a better exception if Popup.Feedback does not get a block
Before: NoMethodError: undefined method `call' for nil:NilClass
After: ArgumentError: block must be supplied
This fixes a RSpec warning about testing a generic exception:
Using the `raise_error` matcher without providing a specific error or message
Commit: 2f5f289ff1a355f48564efe693243b8e660c2e65
https://github.com/yast/yast-yast2/commit/2f5f289ff1a355f48564efe693243b8e66...
Author: Martin Vidner
Date: 2016-07-29 (Fri, 29 Jul 2016)
Changed paths:
M library/general/src/modules/Popup.rb
M library/general/test/popup_test.rb
Log Message:
-----------
Fixed ArgumentError in Popup.AnyTimedMessage (bsc#988739).
It appears that the bug was introduced when we did a large scale change
(removing icons from dialogs) which was not covered with tests.
d4f52319ccdf9c5b3e0f393fbedd95b3b728f82d
This check found one other such bug and no others:
```console
$ ruby-lint -a argument_amount ./library/general/src/modules/Popup.rb
.../yast2/library/general/src/modules/Popup.rb:1771:7:error:wrong number of arguments (expected 3 but got 4)
.../yast2/library/general/src/modules/Popup.rb:1777:7:error:wrong number of arguments (expected 5 but got 6)
```
Commit: e6983e99b7f73f9a46fd948e4ceb60ea46e8efe3
https://github.com/yast/yast-yast2/commit/e6983e99b7f73f9a46fd948e4ceb60ea46...
Author: Martin Vidner
Date: 2016-07-29 (Fri, 29 Jul 2016)
Changed paths:
M package/yast2.changes
M package/yast2.spec
Log Message:
-----------
version + changelog
Compare: https://github.com/yast/yast-yast2/compare/9a7d72abe6fb^...e6983e99b7f7
