Branch: refs/heads/rubocop_update Home: https://github.com/yast/yast-yast2 Commit: 8ea4cb2f52d3da1cee5f476e3fae426e5b147654 https://github.com/yast/yast-yast2/commit/8ea4cb2f52d3da1cee5f476e3fae426e5b... Author: Ladislav Slezák <lslezak@suse.cz> Date: 2016-07-15 (Fri, 15 Jul 2016) Changed paths: M library/general/src/modules/Hooks.rb M library/general/src/modules/Linuxrc.rb M library/general/src/modules/OSRelease.rb M library/general/test/asciifile_test.rb M library/general/test/linuxrc_test.rb M library/network/src/lib/network/firewalld.rb M library/network/src/lib/network/susefirewall2.rb M library/network/src/lib/network/susefirewall2services.rb M library/network/src/lib/network/susefirewalld.rb M library/network/src/lib/network/susefirewalldservices.rb M library/network/src/lib/network/susefirewallservices.rb M library/network/src/modules/NetworkInterfaces.rb M library/network/src/modules/NetworkService.rb M library/network/src/modules/SuSEFirewall.rb M library/network/test/load_ipv6_cfg_test.rb M library/network/test/network_interfaces_helpers_test.rb M library/network/test/susefirewalld_test.rb M library/packages/src/lib/packages/repository.rb M library/packages/src/modules/PackageCallbacks.rb M library/packages/src/modules/Product.rb M library/packages/test/lib/product_test.rb M library/packages/test/product_test.rb M library/system/src/lib/yast2/fs_snapshot.rb M library/system/src/modules/Kernel.rb M library/system/test/fs_snapshot_test.rb M library/systemd/src/lib/yast2/systemctl.rb M library/systemd/src/lib/yast2/systemd_unit.rb M library/systemd/src/modules/systemd_service.rb M library/systemd/src/modules/systemd_socket.rb M library/systemd/src/modules/systemd_target.rb M library/types/src/modules/String.rb M library/types/src/modules/URLRecode.rb M library/types/test/ip_test.rb M library/types/test/string_test.rb M test/test_helper.rb Log Message: ----------- Fixed Style/MutableConstant Commit: ce994ae4651f549b80b41315b46139260811a5ea https://github.com/yast/yast-yast2/commit/ce994ae4651f549b80b41315b461392608... Author: Ladislav Slezák <lslezak@suse.cz> Date: 2016-07-15 (Fri, 15 Jul 2016) Changed paths: M library/types/src/modules/IP.rb Log Message: ----------- Fixed Performance/RangeInclude Commit: e58d9f4c5b989cb9bb7e4a37cd51d64cdfc5b309 https://github.com/yast/yast-yast2/commit/e58d9f4c5b989cb9bb7e4a37cd51d64cdf... Author: Ladislav Slezák <lslezak@suse.cz> Date: 2016-07-15 (Fri, 15 Jul 2016) Changed paths: M library/cwm/src/modules/CWM.rb M library/cwm/src/modules/CWMTable.rb M library/general/src/modules/Arch.rb M library/general/src/modules/Linuxrc.rb M library/general/src/modules/Report.rb M library/general/src/modules/ValueBrowser.rb M library/network/src/lib/network/susefirewall2.rb M library/network/src/lib/network/susefirewalld.rb M library/network/src/modules/CWMFirewallInterfaces.rb M library/network/src/modules/NetworkService.rb M library/wizard/src/modules/Progress.rb Log Message: ----------- Fixed Style/EmptyLineBetweenDefs Commit: 96326791b91884037cd106a53f794a928267842c https://github.com/yast/yast-yast2/commit/96326791b91884037cd106a53f794a9282... Author: Ladislav Slezák <lslezak@suse.cz> Date: 2016-07-15 (Fri, 15 Jul 2016) Changed paths: M library/commandline/src/modules/CommandLine.rb M library/cwm/testsuite/tests/t1.rb M library/cwm/testsuite/tests/t2.rb M library/log/examples/logviewcore1.rb M library/log/examples/logviewcore2.rb M library/log/examples/logviewcore3.rb M library/log/src/modules/LogViewCore.rb M library/network/src/lib/network/susefirewalld.rb M library/network/src/modules/NetworkInterfaces.rb M library/network/src/modules/NetworkService.rb M library/packages/src/lib/packages/repository.rb M library/packages/src/modules/PackageCallbacks.rb M library/sequencer/testsuite/tests/WS_check.rb M library/sequencer/testsuite/tests/Wizard0.rb M library/types/src/modules/String.rb Log Message: ----------- Fixed Style/ExtraSpacing Commit: 210dc58419ab54ecda4d912cd622aba5dadb2117 https://github.com/yast/yast-yast2/commit/210dc58419ab54ecda4d912cd622aba5da... Author: Ladislav Slezák <lslezak@suse.cz> Date: 2016-07-15 (Fri, 15 Jul 2016) Changed paths: M library/commandline/test/clients/dummy_cmdline.rb M library/control/test/ProductFeatures_test.rb Log Message: ----------- Fix Style/AlignHash Commit: b26177dc8c28e6233b117cb5e0094374131167e1 https://github.com/yast/yast-yast2/commit/b26177dc8c28e6233b117cb5e009437413... Author: Ladislav Slezák <lslezak@suse.cz> Date: 2016-07-15 (Fri, 15 Jul 2016) Changed paths: M library/commandline/src/modules/CommandLine.rb M library/control/src/modules/DebugHooks.rb M library/control/src/modules/ProductControl.rb M library/control/src/modules/WorkflowManager.rb M library/cwm/src/modules/CWM.rb M library/cwm/src/modules/CWMTsigKeys.rb M library/general/src/modules/Arch.rb M library/general/src/modules/AsciiFile.rb M library/general/src/modules/Distro.rb M library/general/src/modules/FileUtils.rb M library/general/src/modules/Linuxrc.rb M library/general/src/modules/Misc.rb M library/general/src/modules/Mode.rb M library/general/src/modules/Stage.rb M library/gpg/src/modules/GPG.rb M library/log/src/modules/LogViewCore.rb M library/network/src/lib/network/susefirewall2.rb M library/network/src/lib/network/susefirewall2services.rb M library/network/src/modules/CWMFirewallInterfaces.rb M library/network/src/modules/Internet.rb M library/network/src/modules/NetworkConfig.rb M library/network/src/modules/NetworkInterfaces.rb M library/network/src/modules/PortRanges.rb M library/packages/src/lib/packages/dummy_callbacks.rb M library/packages/src/modules/PackageCallbacks.rb M library/packages/src/modules/PackageSystem.rb M library/packages/src/modules/PackagesUI.rb M library/packages/src/modules/Product.rb M library/packages/src/modules/SignatureCheckCallbacks.rb M library/packages/src/modules/SignatureCheckDialogs.rb M library/packages/src/modules/SlideShow.rb M library/packages/test/product_test.rb M library/system/src/lib/yast2/fs_snapshot.rb M library/system/src/modules/FileChanges.rb M library/system/src/modules/Initrd.rb M library/system/src/modules/ModuleLoading.rb M library/systemd/test/test_helper.rb M library/types/src/modules/Punycode.rb M library/types/src/modules/URL.rb M library/wizard/src/modules/Confirm.rb Log Message: ----------- Fixed Style/ClosingParenthesisIndentation Commit: 1909cc35aefa5412bd7d338f1cbdfac31d703695 https://github.com/yast/yast-yast2/commit/1909cc35aefa5412bd7d338f1cbdfac31d... Author: Ladislav Slezák <lslezak@suse.cz> Date: 2016-07-15 (Fri, 15 Jul 2016) Changed paths: M library/wizard/src/modules/Wizard.rb Log Message: ----------- Fixed Style/SpaceAfterNot Commit: 1557fc75c227666f5e0550b7437a42c31ec84d6b https://github.com/yast/yast-yast2/commit/1557fc75c227666f5e0550b7437a42c31e... Author: Ladislav Slezák <lslezak@suse.cz> Date: 2016-07-15 (Fri, 15 Jul 2016) Changed paths: M library/cwm/src/modules/CWM.rb M library/system/src/modules/ModulesConf.rb M library/wizard/src/modules/Wizard.rb Log Message: ----------- Fixed Style/NestedModifier Commit: c217f521ef41defd19d799153711242e2e396123 https://github.com/yast/yast-yast2/commit/c217f521ef41defd19d799153711242e2e... Author: Ladislav Slezák <lslezak@suse.cz> Date: 2016-07-15 (Fri, 15 Jul 2016) Changed paths: M library/system/src/modules/Kernel.rb Log Message: ----------- Fixed Style/ParenthesesAroundCondition Commit: 1b67aba8986fe4cc3161d3134b411065d55a16a5 https://github.com/yast/yast-yast2/commit/1b67aba8986fe4cc3161d3134b411065d5... Author: Ladislav Slezák <lslezak@suse.cz> Date: 2016-07-15 (Fri, 15 Jul 2016) Changed paths: M library/commandline/src/modules/CommandLine.rb M library/control/src/modules/ProductControl.rb M library/cwm/src/modules/CWM.rb M library/cwm/src/modules/CWMServiceStart.rb M library/cwm/src/modules/TablePopup.rb M library/cwm/src/modules/WizardHW.rb M library/general/src/lib/ui/service_status.rb M library/general/src/modules/Misc.rb M library/general/src/modules/Popup.rb M library/general/src/modules/Report.rb M library/general/src/modules/Summary.rb M library/log/src/modules/LogView.rb M library/network/src/lib/network/susefirewall.rb M library/network/src/lib/network/susefirewall2.rb M library/network/src/lib/network/susefirewalld.rb M library/network/src/lib/network/susefirewalldservices.rb M library/network/src/modules/CWMFirewallInterfaces.rb M library/network/src/modules/Internet.rb M library/network/src/modules/NetworkConfig.rb M library/network/src/modules/NetworkInterfaces.rb M library/network/src/modules/NetworkPopup.rb M library/packages/src/modules/SignatureCheckDialogs.rb M library/packages/src/modules/SlideShow.rb M library/packages/test/dummy_callbacks_test.rb M library/sequencer/doc/examples/examples.rb M library/system/src/modules/Kernel.rb M library/system/src/modules/ModuleLoading.rb M library/types/src/modules/Punycode.rb M library/types/src/modules/String.rb M library/types/src/modules/URL.rb Log Message: ----------- Fixed Style/ConditionalAssignment Commit: c8934057590715fb19104ca3af1096f203b87869 https://github.com/yast/yast-yast2/commit/c8934057590715fb19104ca3af1096f203... Author: Ladislav Slezák <lslezak@suse.cz> Date: 2016-07-15 (Fri, 15 Jul 2016) Changed paths: M library/commandline/src/modules/CommandLine.rb M library/network/src/lib/network/susefirewall.rb M library/network/src/modules/CWMFirewallInterfaces.rb M library/packages/src/modules/SignatureCheckDialogs.rb M library/packages/test/dummy_callbacks_test.rb M library/system/src/modules/Kernel.rb M library/types/src/modules/String.rb Log Message: ----------- Manual refactoring/clean up Commit: cf5032b2eb95d85c02dda611c9503a879e54e9f0 https://github.com/yast/yast-yast2/commit/cf5032b2eb95d85c02dda611c9503a879e... Author: Ladislav Slezák <lslezak@suse.cz> Date: 2016-07-15 (Fri, 15 Jul 2016) Changed paths: M library/commandline/src/modules/CommandLine.rb M library/control/src/modules/ProductControl.rb M library/cwm/src/modules/CWM.rb M library/cwm/src/modules/CWMServiceStart.rb M library/cwm/src/modules/TablePopup.rb M library/cwm/src/modules/WizardHW.rb M library/general/src/lib/ui/service_status.rb M library/general/src/modules/Misc.rb M library/general/src/modules/Popup.rb M library/general/src/modules/Report.rb M library/general/src/modules/Summary.rb M library/log/src/modules/LogView.rb M library/network/src/lib/network/susefirewall2.rb M library/network/src/lib/network/susefirewalld.rb M library/network/src/modules/CWMFirewallInterfaces.rb M library/network/src/modules/Internet.rb M library/network/src/modules/NetworkConfig.rb M library/network/src/modules/NetworkInterfaces.rb M library/network/src/modules/NetworkPopup.rb M library/packages/src/modules/SignatureCheckDialogs.rb M library/packages/src/modules/SlideShow.rb M library/sequencer/doc/examples/examples.rb M library/system/src/modules/Kernel.rb M library/system/src/modules/ModuleLoading.rb M library/types/src/modules/Punycode.rb M library/types/src/modules/String.rb M library/types/src/modules/URL.rb Log Message: ----------- Fixed Style/ElseAlignment Commit: f1697cde8a68b506811997285d81150f3a4038ea https://github.com/yast/yast-yast2/commit/f1697cde8a68b506811997285d81150f3a... Author: Ladislav Slezák <lslezak@suse.cz> Date: 2016-07-15 (Fri, 15 Jul 2016) Changed paths: M library/network/src/lib/network/susefirewall.rb M library/packages/src/modules/SlideShow.rb M library/wizard/src/modules/Wizard.rb Log Message: ----------- Manually fixed Style/IdenticalConditionalBranches Commit: c01ebc67958b659d94ed6d7431ad2e938458ace2 https://github.com/yast/yast-yast2/commit/c01ebc67958b659d94ed6d7431ad2e9384... Author: Ladislav Slezák <lslezak@suse.cz> Date: 2016-07-15 (Fri, 15 Jul 2016) Changed paths: M library/commandline/src/modules/CommandLine.rb M library/control/src/modules/ProductControl.rb M library/cwm/src/modules/CWM.rb M library/cwm/src/modules/CWMServiceStart.rb M library/cwm/src/modules/TablePopup.rb M library/cwm/src/modules/WizardHW.rb M library/general/src/lib/ui/service_status.rb M library/general/src/modules/Misc.rb M library/general/src/modules/Popup.rb M library/general/src/modules/Report.rb M library/general/src/modules/Summary.rb M library/log/src/modules/LogView.rb M library/network/src/lib/network/susefirewall2.rb M library/network/src/lib/network/susefirewalld.rb M library/network/src/modules/CWMFirewallInterfaces.rb M library/network/src/modules/Internet.rb M library/network/src/modules/NetworkConfig.rb M library/network/src/modules/NetworkInterfaces.rb M library/network/src/modules/NetworkPopup.rb M library/packages/src/modules/SignatureCheckDialogs.rb M library/packages/src/modules/SlideShow.rb M library/sequencer/doc/examples/examples.rb M library/system/src/modules/Kernel.rb M library/system/src/modules/ModuleLoading.rb M library/types/src/modules/Punycode.rb M library/types/src/modules/String.rb M library/types/src/modules/URL.rb Log Message: ----------- Fixed Style/IndentationWidth Commit: 16822527de704ea2b42fa4c3678f4c701d3675d0 https://github.com/yast/yast-yast2/commit/16822527de704ea2b42fa4c3678f4c701d... Author: Ladislav Slezák <lslezak@suse.cz> Date: 2016-07-15 (Fri, 15 Jul 2016) Changed paths: M library/commandline/src/modules/CommandLine.rb M library/control/src/modules/ProductControl.rb M library/cwm/src/modules/CWM.rb M library/cwm/src/modules/CWMServiceStart.rb M library/cwm/src/modules/TablePopup.rb M library/cwm/src/modules/WizardHW.rb M library/general/src/modules/Popup.rb M library/network/src/modules/CWMFirewallInterfaces.rb M library/network/src/modules/Internet.rb M library/network/src/modules/NetworkConfig.rb M library/network/src/modules/NetworkInterfaces.rb M library/system/src/modules/ModuleLoading.rb M library/types/src/modules/Punycode.rb Log Message: ----------- Manually fixed Lint/UselessAssignment Commit: fc3d3c276bce1935047ae8d6f27a7a377db1a3ec https://github.com/yast/yast-yast2/commit/fc3d3c276bce1935047ae8d6f27a7a377d... Author: Ladislav Slezák <lslezak@suse.cz> Date: 2016-07-15 (Fri, 15 Jul 2016) Changed paths: M library/general/src/modules/Summary.rb M library/network/src/lib/network/susefirewall2.rb M library/network/src/modules/CWMFirewallInterfaces.rb M library/network/src/modules/NetworkInterfaces.rb M library/network/src/modules/NetworkPopup.rb M library/packages/src/modules/SignatureCheckDialogs.rb M library/packages/src/modules/SlideShow.rb M library/system/src/modules/Kernel.rb M library/types/src/modules/String.rb Log Message: ----------- Fixed Style/CommentIndentation Commit: 425fbccd1c760a2cdacdc7d9e8496e59bb511b22 https://github.com/yast/yast-yast2/commit/425fbccd1c760a2cdacdc7d9e8496e59bb... Author: Ladislav Slezák <lslezak@suse.cz> Date: 2016-07-15 (Fri, 15 Jul 2016) Changed paths: M library/cwm/src/modules/CWM.rb M library/network/src/modules/PortAliases.rb M library/system/src/modules/ModulesConf.rb M library/types/src/modules/IP.rb Log Message: ----------- Fixed Style/RedundantParentheses Commit: 15d0f0f650261afa4281c77fd964ef61eaec6fd5 https://github.com/yast/yast-yast2/commit/15d0f0f650261afa4281c77fd964ef61ea... Author: Ladislav Slezák <lslezak@suse.cz> Date: 2016-07-15 (Fri, 15 Jul 2016) Changed paths: M library/runlevel/test/service_test.rb Log Message: ----------- Fixed Style/SymbolLiteral Commit: 1ec3dfdd0079b47539d88f7df07b882cb44b55a8 https://github.com/yast/yast-yast2/commit/1ec3dfdd0079b47539d88f7df07b882cb4... Author: Ladislav Slezák <lslezak@suse.cz> Date: 2016-07-15 (Fri, 15 Jul 2016) Changed paths: M library/commandline/src/modules/CommandLine.rb M library/control/src/modules/InstError.rb M library/control/src/modules/ProductControl.rb M library/control/src/modules/ProductFeatures.rb M library/control/src/modules/WorkflowManager.rb M library/cwm/src/modules/CWMTsigKeys.rb M library/cwm/src/modules/TablePopup.rb M library/cwm/src/modules/WizardHW.rb M library/general/src/lib/ui/event_dispatcher.rb M library/general/src/modules/Arch.rb M library/general/src/modules/Assert.rb M library/general/src/modules/CustomDialogs.rb M library/general/src/modules/DontShowAgain.rb M library/general/src/modules/FileUtils.rb M library/general/src/modules/Hooks.rb M library/general/src/modules/Misc.rb M library/general/src/modules/Popup.rb M library/general/src/modules/ValueBrowser.rb M library/gpg/src/modules/GPGWidgets.rb M library/network/src/lib/network/susefirewall.rb M library/network/src/lib/network/susefirewall2.rb M library/network/src/modules/CWMFirewallInterfaces.rb M library/network/src/modules/NetworkInterfaces.rb M library/network/src/modules/NetworkService.rb M library/network/src/modules/PortAliases.rb M library/network/src/modules/PortRanges.rb M library/packages/src/modules/SignatureCheckDialogs.rb M library/sequencer/src/modules/Sequencer.rb M library/system/src/modules/FileChanges.rb M library/types/src/modules/IP.rb M library/types/src/modules/Netmask.rb M library/types/src/modules/RichText.rb M library/types/src/modules/String.rb M library/types/src/modules/TypeRepository.rb M library/wizard/src/modules/Wizard.rb M library/xml/src/modules/XML.rb Log Message: ----------- Manually fixed Style/GuardClause Commit: b58069d1c2868b031e4e84f574181529971054c8 https://github.com/yast/yast-yast2/commit/b58069d1c2868b031e4e84f57418152997... Author: Ladislav Slezák <lslezak@suse.cz> Date: 2016-07-15 (Fri, 15 Jul 2016) Changed paths: M library/commandline/src/modules/CommandLine.rb M library/control/src/modules/DebugHooks.rb M library/cwm/src/modules/CWMTable.rb M library/general/src/modules/Misc.rb M library/network/src/lib/network/susefirewall.rb M library/network/src/lib/network/susefirewall2.rb M library/network/src/lib/network/susefirewalld.rb M library/network/src/modules/NetworkInterfaces.rb M library/network/src/modules/PortRanges.rb M library/packages/src/modules/PackageCallbacks.rb M library/packages/src/modules/PackageSystem.rb M library/system/src/modules/Kernel.rb M library/wizard/src/modules/Wizard.rb Log Message: ----------- Manually fixed Style/IfInsideElse Commit: bb7effc415835768ea06efc505b46cd7a1472353 https://github.com/yast/yast-yast2/commit/bb7effc415835768ea06efc505b46cd7a1... Author: Ladislav Slezák <lslezak@suse.cz> Date: 2016-07-15 (Fri, 15 Jul 2016) Changed paths: M library/system/src/modules/FileChanges.rb Log Message: ----------- Fixed Style/RedundantReturn Commit: 76aebcb8b84aa3774e3dea1676fc564ee670fad0 https://github.com/yast/yast-yast2/commit/76aebcb8b84aa3774e3dea1676fc564ee6... Author: Ladislav Slezák <lslezak@suse.cz> Date: 2016-07-15 (Fri, 15 Jul 2016) Changed paths: M library/systemd/test/test_helper.rb Log Message: ----------- Manually fixed Style/NestedParenthesizedCalls Commit: 6255890293a130154dfcb92267d0d3dd5db0a3cb https://github.com/yast/yast-yast2/commit/6255890293a130154dfcb92267d0d3dd5d... Author: Ladislav Slezák <lslezak@suse.cz> Date: 2016-07-15 (Fri, 15 Jul 2016) Changed paths: M library/control/src/modules/WorkflowManager.rb Log Message: ----------- Fixed Style/ExtraSpacing Commit: b9f250537d171db87563f385996d31a5cac3bdee https://github.com/yast/yast-yast2/commit/b9f250537d171db87563f385996d31a5ca... Author: Ladislav Slezák <lslezak@suse.cz> Date: 2016-07-15 (Fri, 15 Jul 2016) Changed paths: M library/control/src/modules/ProductFeatures.rb M library/general/src/modules/FileUtils.rb M library/general/src/modules/ValueBrowser.rb Log Message: ----------- Fixed Style/EmptyElse Commit: 20edadf34c84c53e548a46a6eb68a03dd6ffb905 https://github.com/yast/yast-yast2/commit/20edadf34c84c53e548a46a6eb68a03dd6... Author: Ladislav Slezák <lslezak@suse.cz> Date: 2016-07-15 (Fri, 15 Jul 2016) Changed paths: M library/network/src/modules/NetworkService.rb M library/packages/src/modules/Product.rb M library/runlevel/src/modules/Service.rb Log Message: ----------- Fixed Style/Alias Commit: 33fc568df0621ccedcb0077c772c08071fa11a75 https://github.com/yast/yast-yast2/commit/33fc568df0621ccedcb0077c772c08071f... Author: Ladislav Slezák <lslezak@suse.cz> Date: 2016-07-15 (Fri, 15 Jul 2016) Changed paths: M library/network/src/lib/network/susefirewalld.rb Log Message: ----------- Fixed Performance/Casecmp Commit: 07bdff6b537f53f106278aab5a1b6ac275c0b1f5 https://github.com/yast/yast-yast2/commit/07bdff6b537f53f106278aab5a1b6ac275... Author: Ladislav Slezák <lslezak@suse.cz> Date: 2016-07-15 (Fri, 15 Jul 2016) Changed paths: M library/network/src/lib/network/susefirewall2.rb M library/network/src/modules/PortRanges.rb Log Message: ----------- Fixed Style/CommentIndentation Commit: a8aee91fcc8e8df094eec8bce70e6277112c56fd https://github.com/yast/yast-yast2/commit/a8aee91fcc8e8df094eec8bce70e627711... Author: Ladislav Slezák <lslezak@suse.cz> Date: 2016-07-15 (Fri, 15 Jul 2016) Changed paths: M library/network/src/lib/network/susefirewalld.rb M library/packages/src/modules/SignatureCheckDialogs.rb Log Message: ----------- Manually fixed Style/MultilineTernaryOperator Commit: 13351669616cfe3b3731a71e5b70b1823f281895 https://github.com/yast/yast-yast2/commit/13351669616cfe3b3731a71e5b70b1823f... Author: Ladislav Slezák <lslezak@suse.cz> Date: 2016-07-15 (Fri, 15 Jul 2016) Changed paths: M library/system/src/modules/FileChanges.rb Log Message: ----------- Fixed Style/ElseAlignment Commit: af62e3ce727760406f14e5fdde2b5ea51bb7a207 https://github.com/yast/yast-yast2/commit/af62e3ce727760406f14e5fdde2b5ea51b... Author: Ladislav Slezák <lslezak@suse.cz> Date: 2016-07-15 (Fri, 15 Jul 2016) Changed paths: M library/network/src/lib/network/susefirewalld.rb Log Message: ----------- Fixed Performance/RedundantMatch Commit: 41a5cdbd7920c24bcfacc4fc670d436b270ebb66 https://github.com/yast/yast-yast2/commit/41a5cdbd7920c24bcfacc4fc670d436b27... Author: Ladislav Slezák <lslezak@suse.cz> Date: 2016-07-15 (Fri, 15 Jul 2016) Changed paths: M library/general/src/lib/ui/service_status.rb Log Message: ----------- Manually fixed Lint/UnneededDisable Commit: 686993ed3a9ccd39cf0968c9d1c79e41c0b62453 https://github.com/yast/yast-yast2/commit/686993ed3a9ccd39cf0968c9d1c79e41c0... Author: Ladislav Slezák <lslezak@suse.cz> Date: 2016-07-15 (Fri, 15 Jul 2016) Changed paths: M library/cwm/src/modules/WizardHW.rb M library/general/src/modules/Misc.rb Log Message: ----------- Fixed Style/TrailingWhitespace Commit: 422bede9e4aa6f8b027f07ec0e0e73b169b8e8ce https://github.com/yast/yast-yast2/commit/422bede9e4aa6f8b027f07ec0e0e73b169... Author: Ladislav Slezák <lslezak@suse.cz> Date: 2016-07-15 (Fri, 15 Jul 2016) Changed paths: M library/packages/src/modules/PackageSystem.rb Log Message: ----------- Manually fixed Lint/UselessAssignment Commit: 651d3e216728b7ba5411976629d8c2e4924f8ae1 https://github.com/yast/yast-yast2/commit/651d3e216728b7ba5411976629d8c2e492... Author: Ladislav Slezák <lslezak@suse.cz> Date: 2016-07-15 (Fri, 15 Jul 2016) Changed paths: M library/control/src/modules/ProductControl.rb M library/control/src/modules/ProductFeatures.rb M library/cwm/src/modules/CWMServiceStart.rb M library/cwm/src/modules/CWMTable.rb M library/cwm/src/modules/TablePopup.rb M library/general/src/modules/FileUtils.rb M library/general/src/modules/ValueBrowser.rb M library/network/src/modules/NetworkInterfaces.rb M library/network/src/modules/NetworkPopup.rb M library/network/src/modules/NetworkService.rb M library/network/src/modules/SuSEFirewallExpertRules.rb M library/packages/src/include/packages/common.rb M library/packages/src/modules/PackageCallbacks.rb M library/packages/src/modules/PackageLock.rb M library/runlevel/src/modules/Service.rb M library/types/src/modules/URL.rb Log Message: ----------- Manually fixed Lint/EndAlignment Commit: e354847fc31594f872dc12ad01eefed7813525d5 https://github.com/yast/yast-yast2/commit/e354847fc31594f872dc12ad01eefed781... Author: Ladislav Slezák <lslezak@suse.cz> Date: 2016-07-15 (Fri, 15 Jul 2016) Changed paths: M library/network/src/lib/network/susefirewalld.rb M library/network/test/susefirewalld_test.rb M library/packages/src/modules/Product.rb M library/system/src/lib/yast2/fs_snapshot.rb Log Message: ----------- Fixed Style/MultilineMethodCallBraceLayout Commit: 80d12a6341176987d54e3f6f5c411778ed0e47b4 https://github.com/yast/yast-yast2/commit/80d12a6341176987d54e3f6f5c411778ed... Author: Ladislav Slezák <lslezak@suse.cz> Date: 2016-07-15 (Fri, 15 Jul 2016) Changed paths: M library/system/src/modules/FileChanges.rb Log Message: ----------- Fixed Style/IndentationWidth Commit: 76eec8f3ade7a6e045363912bf5090a7248cf49c https://github.com/yast/yast-yast2/commit/76eec8f3ade7a6e045363912bf5090a724... Author: Ladislav Slezák <lslezak@suse.cz> Date: 2016-07-15 (Fri, 15 Jul 2016) Changed paths: M library/runlevel/src/modules/Service.rb Log Message: ----------- Fixed Style/CaseIndentation Commit: ab54541768a36b70e39e9441acdeb5f6c2225e19 https://github.com/yast/yast-yast2/commit/ab54541768a36b70e39e9441acdeb5f6c2... Author: Ladislav Slezák <lslezak@suse.cz> Date: 2016-07-15 (Fri, 15 Jul 2016) Changed paths: M library/packages/src/modules/PackageCallbacks.rb Log Message: ----------- Fixed Style/IndentAssignment Commit: 853f774d38fd8a82a52d913e4e69d166a1a96504 https://github.com/yast/yast-yast2/commit/853f774d38fd8a82a52d913e4e69d166a1... Author: Ladislav Slezák <lslezak@suse.cz> Date: 2016-07-15 (Fri, 15 Jul 2016) Changed paths: M library/network/src/lib/network/susefirewalld.rb Log Message: ----------- Manually fixed Style/OptionalArguments Fortunately the default value is never used in the YaST code. Commit: 6d5caab134cc4f62d028513810e7399114ed5f99 https://github.com/yast/yast-yast2/commit/6d5caab134cc4f62d028513810e7399114... Author: Ladislav Slezák <lslezak@suse.cz> Date: 2016-07-15 (Fri, 15 Jul 2016) Changed paths: M library/network/src/lib/network/susefirewalld.rb Log Message: ----------- Manually fixed Lint/UselessAccessModifier Commit: a4f759e8d5315a6a588a2a135b7d576b22ef027c https://github.com/yast/yast-yast2/commit/a4f759e8d5315a6a588a2a135b7d576b22... Author: Ladislav Slezák <lslezak@suse.cz> Date: 2016-07-15 (Fri, 15 Jul 2016) Changed paths: M .travis.yml Log Message: ----------- Use new Rubocop at Travis Commit: 95ce3100bcd17612a7d0cfb0e50089b576a55d73 https://github.com/yast/yast-yast2/commit/95ce3100bcd17612a7d0cfb0e50089b576... Author: Ladislav Slezák <lslezak@suse.cz> Date: 2016-07-15 (Fri, 15 Jul 2016) Changed paths: M .rubocop.yml Log Message: ----------- Added Metrics/ModuleLength limit Commit: 0164480fb91916463159ec14d41a2345c2df3e95 https://github.com/yast/yast-yast2/commit/0164480fb91916463159ec14d41a2345c2... Author: Ladislav Slezák <lslezak@suse.cz> Date: 2016-07-15 (Fri, 15 Jul 2016) Changed paths: M library/network/src/modules/SuSEFirewall.rb M library/packages/src/modules/PackagesUI.rb M library/system/src/modules/FileChanges.rb Log Message: ----------- Fixed Style/ZeroLengthPredicate Commit: d6ec6c6a62afb4a89657da764d7bf867677c68f1 https://github.com/yast/yast-yast2/commit/d6ec6c6a62afb4a89657da764d7bf86767... Author: Ladislav Slezák <lslezak@suse.cz> Date: 2016-07-15 (Fri, 15 Jul 2016) Changed paths: M library/commandline/src/modules/CommandLine.rb M library/control/src/modules/ProductControl.rb M library/cwm/src/modules/CWM.rb M library/cwm/src/modules/CWMServiceStart.rb M library/cwm/src/modules/CWMTable.rb M library/cwm/src/modules/TablePopup.rb M library/cwm/src/modules/WizardHW.rb M library/general/src/lib/ui/service_status.rb M library/general/src/modules/Misc.rb M library/general/src/modules/Popup.rb M library/general/src/modules/Report.rb M library/general/src/modules/Summary.rb M library/log/src/modules/LogView.rb M library/network/src/lib/network/susefirewall2.rb M library/network/src/lib/network/susefirewalld.rb M library/network/src/modules/CWMFirewallInterfaces.rb M library/network/src/modules/Internet.rb M library/network/src/modules/NetworkConfig.rb M library/network/src/modules/NetworkInterfaces.rb M library/network/src/modules/NetworkPopup.rb M library/network/src/modules/NetworkService.rb M library/packages/src/include/packages/common.rb M library/packages/src/modules/PackageCallbacks.rb M library/packages/src/modules/PackageLock.rb M library/packages/src/modules/SignatureCheckDialogs.rb M library/packages/src/modules/SlideShow.rb M library/sequencer/doc/examples/examples.rb M library/system/src/modules/FileChanges.rb M library/system/src/modules/Kernel.rb M library/system/src/modules/ModuleLoading.rb M library/types/src/modules/Punycode.rb M library/types/src/modules/String.rb M library/types/src/modules/URL.rb Log Message: ----------- Fixed Style/ElseAlignment Commit: a79134585605c12862408638fb23160d7c70e242 https://github.com/yast/yast-yast2/commit/a79134585605c12862408638fb23160d7c... Author: Ladislav Slezák <lslezak@suse.cz> Date: 2016-07-15 (Fri, 15 Jul 2016) Changed paths: M library/commandline/src/modules/CommandLine.rb M library/control/src/modules/ProductControl.rb M library/cwm/src/modules/CWM.rb M library/cwm/src/modules/CWMServiceStart.rb M library/cwm/src/modules/CWMTable.rb M library/cwm/src/modules/TablePopup.rb M library/cwm/src/modules/WizardHW.rb M library/general/src/lib/ui/service_status.rb M library/general/src/modules/Misc.rb M library/general/src/modules/Popup.rb M library/general/src/modules/Report.rb M library/general/src/modules/Summary.rb M library/log/src/modules/LogView.rb M library/network/src/lib/network/susefirewall2.rb M library/network/src/lib/network/susefirewalld.rb M library/network/src/modules/CWMFirewallInterfaces.rb M library/network/src/modules/Internet.rb M library/network/src/modules/NetworkConfig.rb M library/network/src/modules/NetworkInterfaces.rb M library/network/src/modules/NetworkPopup.rb M library/network/src/modules/NetworkService.rb M library/packages/src/include/packages/common.rb M library/packages/src/modules/PackageCallbacks.rb M library/packages/src/modules/PackageLock.rb M library/packages/src/modules/SignatureCheckDialogs.rb M library/packages/src/modules/SlideShow.rb M library/sequencer/doc/examples/examples.rb M library/system/src/modules/FileChanges.rb M library/system/src/modules/Kernel.rb M library/system/src/modules/ModuleLoading.rb M library/types/src/modules/Punycode.rb M library/types/src/modules/String.rb M library/types/src/modules/URL.rb Log Message: ----------- Fixed Style/IndentationWidth Commit: 769492d9643298d9b0028efedef5ad278ff6629d https://github.com/yast/yast-yast2/commit/769492d9643298d9b0028efedef5ad278f... Author: Ladislav Slezák <lslezak@suse.cz> Date: 2016-07-15 (Fri, 15 Jul 2016) Changed paths: M library/general/src/modules/Summary.rb M library/network/src/lib/network/susefirewall2.rb M library/network/src/modules/CWMFirewallInterfaces.rb M library/network/src/modules/NetworkInterfaces.rb M library/network/src/modules/NetworkPopup.rb M library/packages/src/include/packages/common.rb M library/packages/src/modules/PackageCallbacks.rb M library/packages/src/modules/SignatureCheckDialogs.rb M library/packages/src/modules/SlideShow.rb M library/system/src/modules/FileChanges.rb M library/system/src/modules/Kernel.rb M library/types/src/modules/String.rb Log Message: ----------- Fixed Style/CommentIndentation Commit: 4c1af1883c2605fcc4e5e03804664120cc2c144b https://github.com/yast/yast-yast2/commit/4c1af1883c2605fcc4e5e03804664120cc... Author: Ladislav Slezák <lslezak@suse.cz> Date: 2016-07-15 (Fri, 15 Jul 2016) Changed paths: M library/network/src/modules/SuSEFirewallExpertRules.rb M library/runlevel/src/modules/Service.rb Log Message: ----------- Manually fixed Lint/EndAlignment Commit: 34a411fedf1ce26b4503fcd8fe8162c175a33a3f https://github.com/yast/yast-yast2/commit/34a411fedf1ce26b4503fcd8fe8162c175... Author: Ladislav Slezák <lslezak@suse.cz> Date: 2016-07-15 (Fri, 15 Jul 2016) Changed paths: M library/commandline/testsuite/tests/interactive4.rb M library/control/testsuite/tests/ProductProfile.rb M library/control/testsuite/tests/restore.rb M library/general/testsuite/tests/FileUtils.rb M library/network/testsuite/tests/PortAliases.rb M library/network/testsuite/tests/SuSEFirewall.rb M library/packages/src/modules/PackagesUI.rb M library/packages/test/package_callbacks_test.rb M library/runlevel/testsuite/tests/Systemd.rb M library/system/testsuite/tests/filechanges.rb M library/system/testsuite/tests/initrd.rb M library/system/testsuite/tests/kernel.rb Log Message: ----------- Fixed Style/IndentArray Commit: 0c9947b19403977df071668cf6372099f035047f https://github.com/yast/yast-yast2/commit/0c9947b19403977df071668cf6372099f0... Author: Ladislav Slezák <lslezak@suse.cz> Date: 2016-07-15 (Fri, 15 Jul 2016) Changed paths: M library/network/src/modules/NetworkService.rb M library/packages/src/modules/Product.rb M library/runlevel/src/modules/Service.rb Log Message: ----------- Fixed Style/Alias Commit: 5e2c42345169d31c4cf1a8643ad0b6d7e1a4a58f https://github.com/yast/yast-yast2/commit/5e2c42345169d31c4cf1a8643ad0b6d7e1... Author: Ladislav Slezák <lslezak@suse.cz> Date: 2016-07-15 (Fri, 15 Jul 2016) Changed paths: M library/systemd/src/lib/yast2/systemd_unit.rb Log Message: ----------- Fixed Style/SpaceInsidePercentLiteralDelimiters Commit: 3b5432f2401ed64fe4f5da998a901cd5c8f82bbc https://github.com/yast/yast-yast2/commit/3b5432f2401ed64fe4f5da998a901cd5c8... Author: Ladislav Slezák <lslezak@suse.cz> Date: 2016-07-15 (Fri, 15 Jul 2016) Changed paths: M library/systemd/test/test_helper.rb Log Message: ----------- Fixed Style/ClosingParenthesisIndentation Commit: 24f3469aaff90fa9ed9f83e6808150fe78879f36 https://github.com/yast/yast-yast2/commit/24f3469aaff90fa9ed9f83e6808150fe78... Author: Ladislav Slezák <lslezak@suse.cz> Date: 2016-07-15 (Fri, 15 Jul 2016) Changed paths: M .rubocop.yml Log Message: ----------- Increase the Metrics/MethodLength limit Ok, it's a bit cheating... Commit: 81d32283a5d93c79c66a4da2954ed67bfcbba271 https://github.com/yast/yast-yast2/commit/81d32283a5d93c79c66a4da2954ed67bfc... Author: Ladislav Slezák <lslezak@suse.cz> Date: 2016-07-15 (Fri, 15 Jul 2016) Changed paths: M .travis.yml Log Message: ----------- Update Rubocop at Travis Commit: 981af5f20bce661f824e53b09441ce50375d9e68 https://github.com/yast/yast-yast2/commit/981af5f20bce661f824e53b09441ce5037... Author: Ladislav Slezák <lslezak@suse.cz> Date: 2016-07-15 (Fri, 15 Jul 2016) Changed paths: M library/control/src/modules/ProductFeatures.rb M library/control/src/modules/WorkflowManager.rb M library/general/src/modules/Hooks.rb M library/general/src/modules/ValueBrowser.rb M library/network/src/modules/CWMFirewallInterfaces.rb M library/network/src/modules/NetworkService.rb M library/packages/src/modules/PackageSystem.rb M library/sequencer/src/modules/Sequencer.rb M library/system/src/modules/FileChanges.rb M library/types/src/modules/IP.rb M library/types/src/modules/String.rb M library/types/src/modules/TypeRepository.rb Log Message: ----------- Code review fixes Compare: https://github.com/yast/yast-yast2/compare/91c27d83b8d0...981af5f20bce