See http://river.suse.de/job/yast-migration-master/26/changes Changes: [Jiri Srain] use snapper directly since fs_snapshot relies on newer version of snapper, which is and will not be available in GA [Jiri Srain] test offenses [Jiri Srain] superfluous [Jiri Srain] offenses, test update [Jiri Srain] test [Jiri Srain] method split [Jiri Srain] rubocop [Jiri Srain] rubocop ------------------------------------------ [...truncated 506 lines...] [ 19s] ... removing all built rpms [ 19s] (order: reverse yast2-migration) [ 19s] [ 19s] RPMLINT report: [ 19s] =============== [ 19s] yast2-migration.noarch: W: wrong-file-end-of-line-encoding /usr/share/doc/packages/yast2-migration/README.md [ 19s] This file has wrong end-of-line encoding, usually caused by creation or [ 19s] modification on a non-Unix system. It could prevent it from being displayed [ 19s] correctly in some circumstances. [ 19s] [ 19s] yast2-migration.noarch: W: desktopfile-without-binary /usr/share/applications/YaST2/migration.desktop xdg-su [ 19s] the .desktop file is for a file not present in the package. You should check [ 19s] the requires or see if this is not a error [ 19s] [ 19s] 2 packages and 0 specfiles checked; 0 errors, 2 warnings. [ 19s] [ 19s] [ 19s] vm-yast-ci-worker3 finished "build yast2-migration.spec" at Fri Jun 19 08:16:36 UTC 2015. [ 19s] Building yast2-migration.spec for SLE-12-SP1/x86_64 Getting buildinfo from server and store to http://river.suse.de/job/yast-migration-master/ws/Devel:YaST:Head/yast2-migration/.osc/_buildinfo-SLE-12-SP1-x86_64.xml Getting buildconfig from server and store to http://river.suse.de/job/yast-migration-master/ws/Devel:YaST:Head/yast2-migration/.osc/_buildconfig-SLE-12-SP1-x86_64 Updating cache of required packages 0.9% cache miss. 211/213 dependencies cached. 1/2 (Devel:YaST:Head) yast2-packager-3.1.71-2.5.x86_64.rpm 2/2 (Devel:YaST:Head) yast2-storage-3.1.57-1.2.x86_64.rpm Skipping verification of package signatures Writing build configuration Running build /var/tmp/build-root-SLE-12-SP1/home/abuild/rpmbuild/SRPMS/yast2-migration-3.1.0-1.src.rpm /var/tmp/build-root-SLE-12-SP1/home/abuild/rpmbuild/RPMS/noarch/yast2-migration-3.1.0-1.noarch.rpm rm -rf Devel:YaST:Head osc -A 'https://api.suse.de/' --traceback --verbose checkout 'Devel:YaST:Head' yast2-migration cleaning makeurl: https://api.suse.de ['source', 'Devel:YaST:Head', 'yast2-migration', '_meta'] {} makeurl: https://api.suse.de ['source', 'Devel:YaST:Head', 'yast2-migration'] {'rev': 'latest'} A Devel:YaST:Head makeurl: https://api.suse.de ['source', 'Devel:YaST:Head'] {} A Devel:YaST:Head/yast2-migration makeurl: https://api.suse.de ['source', 'Devel:YaST:Head'] {} makeurl: https://api.suse.de ['source', 'Devel:YaST:Head', 'yast2-migration'] {'rev': 'latest'} makeurl: https://api.suse.de ['source', 'Devel:YaST:Head', 'yast2-migration', 'yast2-migration-3.1.0.tar.bz2'] {'rev': '19'} A Devel:YaST:Head/yast2-migration/yast2-migration-3.1.0.tar.bz2 makeurl: https://api.suse.de ['source', 'Devel:YaST:Head', 'yast2-migration', 'yast2-migration.changes'] {'rev': '19'} A Devel:YaST:Head/yast2-migration/yast2-migration.changes makeurl: https://api.suse.de ['source', 'Devel:YaST:Head', 'yast2-migration', 'yast2-migration.spec'] {'rev': '19'} A Devel:YaST:Head/yast2-migration/yast2-migration.spec makeurl: https://api.suse.de ['source', 'Devel:YaST:Head', 'yast2-migration', '_meta'] {} At revision 19. /usr/lib/obs/service/format_spec_file --outdir . diff -u package/yast2-migration.spec http://river.suse.de/job/yast-migration-master/ws/Devel:YaST:Head/yast2-migration/yast2-migration.spec tar xvf package/yast2-migration-3.1.0.tar.bz2 -C /tmp/unpacked_tarball20150619-13176-o276ej yast2-migration-3.1.0/ yast2-migration-3.1.0/README.md yast2-migration-3.1.0/src/ yast2-migration-3.1.0/src/lib/ yast2-migration-3.1.0/src/lib/migration/ yast2-migration-3.1.0/src/lib/migration/main_workflow.rb yast2-migration-3.1.0/src/lib/migration/proposal_store.rb yast2-migration-3.1.0/src/clients/ yast2-migration-3.1.0/src/clients/migration.rb yast2-migration-3.1.0/src/clients/migration_proposals.rb yast2-migration-3.1.0/src/.gitkeep yast2-migration-3.1.0/src/desktop/ yast2-migration-3.1.0/src/desktop/migration.desktop yast2-migration-3.1.0/package/ yast2-migration-3.1.0/package/yast2-migration.spec yast2-migration-3.1.0/package/yast2-migration.changes yast2-migration-3.1.0/RPMNAME yast2-migration-3.1.0/doc/ yast2-migration-3.1.0/doc/.gitkeep yast2-migration-3.1.0/.coveralls.yml yast2-migration-3.1.0/test/ yast2-migration-3.1.0/test/test_helper.rb yast2-migration-3.1.0/test/main_workflow_test.rb yast2-migration-3.1.0/test/proposal_store_test.rb yast2-migration-3.1.0/.rubocop.yml yast2-migration-3.1.0/.travis.yml yast2-migration-3.1.0/.yardopts yast2-migration-3.1.0/CONTRIBUTING.md yast2-migration-3.1.0/Rakefile yast2-migration-3.1.0/COPYING tar xvf http://river.suse.de/job/yast-migration-master/ws/Devel:YaST:Head/yast2-migration/yast2-migration-3.1.0.tar.bz2 -C /tmp/unpacked_tarball20150619-13176-142vwy6 yast2-migration-3.1.0/ yast2-migration-3.1.0/README.md yast2-migration-3.1.0/src/ yast2-migration-3.1.0/src/lib/ yast2-migration-3.1.0/src/lib/migration/ yast2-migration-3.1.0/src/lib/migration/main_workflow.rb yast2-migration-3.1.0/src/lib/migration/proposal_store.rb yast2-migration-3.1.0/src/clients/ yast2-migration-3.1.0/src/clients/migration.rb yast2-migration-3.1.0/src/clients/migration_proposals.rb yast2-migration-3.1.0/src/.gitkeep yast2-migration-3.1.0/src/desktop/ yast2-migration-3.1.0/src/desktop/migration.desktop yast2-migration-3.1.0/package/ yast2-migration-3.1.0/package/yast2-migration.spec yast2-migration-3.1.0/package/yast2-migration.changes yast2-migration-3.1.0/RPMNAME yast2-migration-3.1.0/doc/ yast2-migration-3.1.0/doc/.gitkeep yast2-migration-3.1.0/.coveralls.yml yast2-migration-3.1.0/test/ yast2-migration-3.1.0/test/test_helper.rb yast2-migration-3.1.0/test/main_workflow_test.rb yast2-migration-3.1.0/test/proposal_store_test.rb yast2-migration-3.1.0/.rubocop.yml yast2-migration-3.1.0/.travis.yml yast2-migration-3.1.0/.yardopts yast2-migration-3.1.0/CONTRIBUTING.md yast2-migration-3.1.0/Rakefile yast2-migration-3.1.0/COPYING rm http://river.suse.de/job/yast-migration-master/ws/Devel:YaST:Head/yast2-migration/yast2-migration.spec rm http://river.suse.de/job/yast-migration-master/ws/Devel:YaST:Head/yast2-migration/yast2-migration-3.1.0.tar.bz2 rm http://river.suse.de/job/yast-migration-master/ws/Devel:YaST:Head/yast2-migration/yast2-migration.changes cp package/yast2-migration.spec http://river.suse.de/job/yast-migration-master/ws/Devel:YaST:Head/yast2-migration cp package/yast2-migration-3.1.0.tar.bz2 http://river.suse.de/job/yast-migration-master/ws/Devel:YaST:Head/yast2-migration cp package/yast2-migration.changes http://river.suse.de/job/yast-migration-master/ws/Devel:YaST:Head/yast2-migration osc -A 'https://api.suse.de/' addremove diff -ur /tmp/unpacked_tarball20150619-13176-o276ej/yast2-migration-3.1.0/src/lib/migration/main_workflow.rb /tmp/unpacked_tarball20150619-13176-142vwy6/yast2-migration-3.1.0/src/lib/migration/main_workflow.rb --- /tmp/unpacked_tarball20150619-13176-o276ej/yast2-migration-3.1.0/src/lib/migration/main_workflow.rb 2015-06-19 08:16:01.501755183 +0000 +++ /tmp/unpacked_tarball20150619-13176-142vwy6/yast2-migration-3.1.0/src/lib/migration/main_workflow.rb 2015-06-11 09:10:57.061682420 +0000 @@ -19,12 +19,12 @@ # ------------------------------------------------------------------------------ require "yast" +require "yast2/fs_snapshot" Yast.import "Mode" Yast.import "Pkg" Yast.import "Sequencer" Yast.import "Update" -Yast.import "Report" module Migration # The goal of the class is to provide main single entry point to start @@ -32,13 +32,6 @@ # class MainWorkflow include Yast::Logger - include Yast::I18n - - FIND_CONFIG_CMD = "/usr/bin/snapper --no-dbus list-configs | " \ - "grep "^root " >/dev/null" - CREATE_SNAPSHOT_CMD = "/usr/bin/snapper create --type=%{snapshot_type} " \ - "--cleanup-algorithm=number --print-number " \ - "--description="%{description}"" def self.run workflow = new @@ -46,7 +39,6 @@ end def run - textdomain "migration" Yast::Mode.SetMode("update") Yast::Sequencer.Run(aliases, WORKFLOW_SEQUENCE) end @@ -128,29 +120,9 @@ end def create_snapshot - perform_snapshot if snapper_configured? - :next - end + Yast2::FsSnapshot.create_single("before update on migration") - def snapper_configured? - out = Yast::SCR.Execute(Yast::Path.new(".target.bash_output"), - FIND_CONFIG_CMD) - - log.info("Checking if Snapper is configured: "#{FIND_CONFIG_CMD}" " \ - "returned: #{out}") - out["exit"] == 0 - end - - def perform_snapshot - cmd = format(CREATE_SNAPSHOT_CMD, - snapshot_type: :single, - description: "before update on migration") - - out = Yast::SCR.Execute(Yast::Path.new(".target.bash_output"), cmd) - return :next if out["exit"] == 0 - - log.error "Snapshot could not be created: #{cmd} returned: #{out}" - Yast::Report.Error(_("Failed to create filesystem snapshot.")) + :next end end end diff -ur /tmp/unpacked_tarball20150619-13176-o276ej/yast2-migration-3.1.0/test/main_workflow_test.rb /tmp/unpacked_tarball20150619-13176-142vwy6/yast2-migration-3.1.0/test/main_workflow_test.rb --- /tmp/unpacked_tarball20150619-13176-o276ej/yast2-migration-3.1.0/test/main_workflow_test.rb 2015-06-19 08:16:01.501755183 +0000 +++ /tmp/unpacked_tarball20150619-13176-142vwy6/yast2-migration-3.1.0/test/main_workflow_test.rb 2015-06-11 09:10:57.061682420 +0000 @@ -47,12 +47,11 @@ mock_client("inst_kickoff", :next) mock_client("inst_rpmcopy", :next) - cmd_success = { "exit" => 0 } - cmd_fail = { "exit" => 1 } allow(Yast::Update).to receive(:clean_backup) allow(Yast::Update).to receive(:create_backup) allow(Yast::Update).to receive(:restore_backup) - allow(Yast::SCR).to receive(:Execute).and_return(cmd_success, cmd_fail) + allow(Yast2::FsSnapshot).to receive(:create_single) + .with("before update on migration") end it "pass workflow sequence to Yast sequencer" do submitting package... osc -A https://api.suse.de/ commit -m Updated to git ref 5f370ec Sending yast2-migration-3.1.0.tar.bz2 Transmitting file data . Committed revision 20. rm -rf Devel:YaST:Head osc -A 'https://api.suse.de/' --traceback --verbose checkout 'Devel:YaST:Head' yast2-migration New package submitted to Devel:YaST:Head cleaning makeurl: https://api.suse.de ['source', 'Devel:YaST:Head', 'yast2-migration', '_meta'] {} makeurl: https://api.suse.de ['source', 'Devel:YaST:Head', 'yast2-migration'] {'rev': 'latest'} A Devel:YaST:Head makeurl: https://api.suse.de ['source', 'Devel:YaST:Head'] {} A Devel:YaST:Head/yast2-migration makeurl: https://api.suse.de ['source', 'Devel:YaST:Head'] {} makeurl: https://api.suse.de ['source', 'Devel:YaST:Head', 'yast2-migration'] {'rev': 'latest'} makeurl: https://api.suse.de ['source', 'Devel:YaST:Head', 'yast2-migration', 'yast2-migration-3.1.0.tar.bz2'] {'rev': '20'} A Devel:YaST:Head/yast2-migration/yast2-migration-3.1.0.tar.bz2 makeurl: https://api.suse.de ['source', 'Devel:YaST:Head', 'yast2-migration', 'yast2-migration.changes'] {'rev': '20'} A Devel:YaST:Head/yast2-migration/yast2-migration.changes makeurl: https://api.suse.de ['source', 'Devel:YaST:Head', 'yast2-migration', 'yast2-migration.spec'] {'rev': '20'} A Devel:YaST:Head/yast2-migration/yast2-migration.spec makeurl: https://api.suse.de ['source', 'Devel:YaST:Head', 'yast2-migration', '_meta'] {} At revision 20. osc -A 'https://api.suse.de/' cat 'SUSE:SLE-12-SP1:GA' 'yast2-migration' 'yast2-migration.spec' > /tmp/yast-rake20150619-13176-f8f7sx expanding link... Server returned an error: HTTP Error 404: Not Found SUSE:SLE-12-SP1:GA/yast2-migration rm -rf Devel:YaST:Head rake aborted! Command failed with status (1): [osc -A 'https://api.suse.de/' cat 'SUSE:SL...] Tasks: TOP => osc:sr (See full trace by running task with --trace) cleaning Build step 'Execute shell' marked build as failure